[GitHub] [airflow] Taragolis commented on a diff in pull request #34683: Add support for ZoneInfo and generic UTC

["Taragolis (via GitHub)" <gi...@apache.org>]

Taragolis commented on code in PR #34683:
URL: https://github.com/apache/airflow/pull/34683#discussion_r1341256083


##########
airflow/serialization/serializers/timezone.py:
##########
@@ -69,4 +82,28 @@ def deserialize(classname: str, version: int, data: object) -> Timezone:
     if isinstance(data, int):
         return fixed_timezone(data)
 
+    if "zoneinfo.ZoneInfo" in classname:  # capturing backports and stdlib
+        if PY39:
+            from zoneinfo import ZoneInfo
+        else:
+            from backports.zoneinfo import ZoneInfo

Review Comment:
   Maybe we could use "old fashioned" try: except ? I'm biased towards to imports from `airflow` package because time to time it cause Circular Import Error
   
   ```suggestion
           try:
               from zoneinfo import ZoneInfo
           except ImportError:
               from backports.zoneinfo import ZoneInfo
   ```
   
   And could we move it in to the root of the module? Or is it quite expensive import?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org