You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/03/06 00:09:17 UTC
[GitHub] [incubator-superset] michellethomas commented on issue #6956:
Adding custom control overrides
michellethomas commented on issue #6956: Adding custom control overrides
URL: https://github.com/apache/incubator-superset/pull/6956#issuecomment-469911297
I'm not sure how the old isEqual code worked, maybe it didn't. I noticed because it wasn't catching if columns was a different length.
Sorry for the churn, I noticed an issue with the way I was clearing metrics in the MetricsControl so I fixed that logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org