[GitHub] [hadoop] steveloughran commented on a change in pull request #2278: HADOOP-17191. ABFS: Run the integration tests with various combinations of configurations and publish a consolidated results

[GitBox <gi...@apache.org>]

steveloughran commented on a change in pull request #2278:
URL: https://github.com/apache/hadoop/pull/2278#discussion_r500379235



##########
File path: hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md
##########
@@ -80,7 +80,7 @@ tests against mocked storage, which is an in-memory emulation of Azure Storage.
 The integration tests are designed to test directly against an Azure storage
 service, and require an account and credentials in order to run.
 
-This is done by creating the file to `src/test/resources/azure-auth-keys.xml`
+This is done by creating the file to `src/test/resources/abfs-testrun-configs.xml`

Review comment:
       how will this work with the wasb tests? They don't get run through these shell scripts, do they?

##########
File path: hadoop-tools/hadoop-azure/src/test/resources/abfs-testrun-configs.xml.template
##########
@@ -0,0 +1,181 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+  Licensed under the Apache License, Version 2.0 (the "License");
+  you may not use this file except in compliance with the License.
+  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing, software
+  distributed under the License is distributed on an "AS IS" BASIS,
+  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+  See the License for the specific language governing permissions and
+  limitations under the License.
+-->
+
+<configuration>
+
+  <!--====================== IMPORTANT!! ========================-->
+  <!--
+      1. PLEASE PROVIDE VALUES FOR THE CONFIGS IN THIS FILE AND

Review comment:
       instructions should be "copy and then edit". That ensures that secrets are never added to scm-managed files

##########
File path: hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAzureBlobFileSystemDelegationSAS.java
##########
@@ -64,7 +64,7 @@
       LoggerFactory.getLogger(ITestAzureBlobFileSystemDelegationSAS.class);
 
   public ITestAzureBlobFileSystemDelegationSAS() throws Exception {
-    // These tests rely on specific settings in azure-auth-keys.xml:
+    // These tests rely on specific settings in abfs-testrun-configs.xml:

Review comment:
       Please revert. I am not worried that it contains extra details and prefer backwards compatibility.
   
   FWIW my auth-keys XIncludes to somewhere outside the source tree which already contains a lot more binding info than the secrets; it's managed under SCM in that private (local only) git repo and I am happy with the process. Whatever process is developed here, it MUST allow me to refer to template options in absolute paths outside of this source tree. 

##########
File path: hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md
##########
@@ -935,3 +935,30 @@ http[s]://[account][domain-suffix]/[filesystem], please use the following:
   <value>{IP}:{PORT}</value>
 </property>
 ```
+
+##Run different combinations of tests using the runtests.sh script
+
+This is the expected way in which the tests have to be ran before raising a PR.
+The script runtests.sh contain template for 3 combinations of tests. Ensure

Review comment:
       use backtick ` encoding for all scripts

##########
File path: hadoop-tools/hadoop-azure/src/site/markdown/testing_azure.md
##########
@@ -935,3 +935,30 @@ http[s]://[account][domain-suffix]/[filesystem], please use the following:
   <value>{IP}:{PORT}</value>
 </property>
 ```
+
+##Run different combinations of tests using the runtests.sh script
+
+This is the expected way in which the tests have to be ran before raising a PR.
+The script runtests.sh contain template for 3 combinations of tests. Ensure
+the auth configs for all the accounts used for testing are provided in
+abfs-testrun-configs.xml. In case any new flags or properties are introduced
+with the code change, add the combinations with the possible configurations
+into the runtests.sh. The thread count can be specified as the command line
+argument for the script. By default the same will be 8.
+
+Adding a combination of tests involves setting the variable scenario (ex: HNS
+-OAuth) and specifying the specific configurations for the particular
+combination with 2 arrays namely properties and values. Specify the property
+names within the array properties and corresponding values in the values
+array. The property and value is determined by the array index. The value for
+the property mentioned at index 1 of array properties should be specified at
+index 1 of the array values. Call the function runtestwithconfs once the 3
+values mentioned are set. Now the script runtests.sh is ready to be ran.
+
+Once the tests are completed, logs will be present in the directory
+target/testlogs. A consolidated test results will be present in the file
+Test-$starttime-Results.log, $startname will be the start time of the test.
+Similarly, the full test report can be found in individual log files, for each
+of the scenarios with the file name Test-$starttime-Logs-$scenario. Please
+attach the consolidates test results from the file Test-$starttime-Results.log

Review comment:
       consolidated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org