You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/06/08 19:16:33 UTC

[GitHub] [tvm] tkonolige opened a new pull request #8217: [TIR] Fix data dependent indexing when lowering TE to TIR

tkonolige opened a new pull request #8217:
URL: https://github.com/apache/tvm/pull/8217


   A conversion pass was missing the recursive VisitExpr statement.
   
   @junrushao1994 @Hzfengsy @vinx13 @MasterJH5574 @tqchen


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 merged pull request #8217: [TIR] Fix data dependent indexing when lowering TE to TIR

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #8217:
URL: https://github.com/apache/tvm/pull/8217


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #8217: [TIR] Fix data dependent indexing when lowering TE to TIR

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8217:
URL: https://github.com/apache/tvm/pull/8217#issuecomment-857371364


   Thanks @tkonolige @tqchen @Hzfengsy!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #8217: [TIR] Fix data dependent indexing when lowering TE to TIR

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8217:
URL: https://github.com/apache/tvm/pull/8217#issuecomment-857043830


   Thanks Tristan for the fix!
   
   A takeaway here is that we should always prefer recursive visit by calling `StmtExprMutator::VisitExpr_` @Hzfengsy @spectrometerHBH 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org