You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/12/01 19:00:32 UTC
[GitHub] [incubator-superset] ktmud commented on a change in pull request #11847: fix: Show copy icon
ktmud commented on a change in pull request #11847:
URL: https://github.com/apache/incubator-superset/pull/11847#discussion_r533650285
##########
File path: superset-frontend/src/explore/components/DisplayQueryButton.jsx
##########
@@ -186,9 +204,12 @@ export const DisplayQueryButton = props => {
text={query}
shouldShowText={false}
copyNode={
- <Button style={{ position: 'absolute', right: 20 }}>
+ <CopyButtonViewQuery>
<i className="fa fa-clipboard" />
- </Button>
+ </CopyButtonViewQuery>
+ // <Button style={{ position: 'absolute', right: 20}}>
+ // <i className="fa fa-clipboard" style={{ padding: 0 }}/>
+ // </Button>
Review comment:
Can we remove the comments?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org