You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/12/03 14:35:06 UTC
[GitHub] [iceberg] rajarshisarkar opened a new pull request #3660: Core: Change variable name to metadataFile in CatalogUtil's dropTableData
rajarshisarkar opened a new pull request #3660:
URL: https://github.com/apache/iceberg/pull/3660
Raising a small change to change the variable name from `list` to `metadataFile` as `metadata.metadataFileLocation()` would give the current metadata file (and not a list).
This change is also consistent with the previous lines where the previous metadata files are deleted: https://github.com/apache/iceberg/blob/master/core/src/main/java/org/apache/iceberg/CatalogUtil.java#L114-L117
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #3660: Core: Change variable name to metadataFile in CatalogUtil's dropTableData
Posted by GitBox <gi...@apache.org>.
jackye1995 merged pull request #3660:
URL: https://github.com/apache/iceberg/pull/3660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #3660: Core: Change variable name to metadataFile in CatalogUtil's dropTableData
Posted by GitBox <gi...@apache.org>.
jackye1995 commented on pull request #3660:
URL: https://github.com/apache/iceberg/pull/3660#issuecomment-985735668
Thanks, I was just about to create an issue for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org