[GitHub] [netbeans] emilianbold commented on issue #1288: [NETBEANS-2653] Generate toString() with StringBuilder

[GitBox <gi...@apache.org>]

emilianbold commented on issue #1288: [NETBEANS-2653] Generate toString() with StringBuilder
URL: https://github.com/apache/netbeans/pull/1288#issuecomment-500224705
 
 
   Hm, interesting remark. So in this case leaving the + is best as the
   compiler takes care of everything.
   
   There is on case where using stringbuilder might be nice: as a first
   version that gets modified by hand, for example to conditionally append
   some text. I suspect in that case the compiler will create multiple
   stringbuilder while in our case the user would remove a line a replace it
   with an if.
   
   In this situation we need that checkbox.
   
   --emi
   
   dum., 9 iun. 2019, 18:45 Neil C Smith <no...@github.com> a scris:
   
   > But we also could have replaced the old code with StringBuilder and call
   > it a day.
   >
   > Given JEP 280 wouldn't that be the wrong approach? Actually, I'm dubious
   > about this PR.
   >
   > —
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/netbeans/pull/1288?email_source=notifications&email_token=AAHSCQX53MOIOAI4BGZBBADPZUQSVA5CNFSM4HWIWR32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXIMXLI#issuecomment-500222893>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/AAHSCQWY6C5BG4QS57FYVU3PZUQSVANCNFSM4HWIWR3Q>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists