[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #6612: Spec: View spec rename sql field to query

[GitBox <gi...@apache.org>]

amogh-jahagirdar commented on code in PR #6612:
URL: https://github.com/apache/iceberg/pull/6612#discussion_r1073137599


##########
format/view-spec.md:
##########
@@ -107,7 +107,7 @@ This type of representation stores the original view definition in SQL and its S
 | Required/Optional | Field Name | Description |
 |-------------------|------------|-------------|
 | Required | type | A string indicating the type of representation. It is set to "sql" for this type. |
-| Required | sql | A string representing the original view definition in SQL |
+| Required | query | A string representing the original view definition in SQL |

Review Comment:
   Yeah good point, in my mind query was more broader than just SQL but yeah ultimately this is for SQLViewRepresentation which will by definition just be SQL. I'll close this and raise a PR to update the API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org