You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Jasha Joachimsthal (Created) (JIRA)" <ji...@apache.org> on 2011/11/01 16:13:32 UTC
[jira] [Created] (RAVE-332) Change logic of adding a duplicate
widget
Change logic of adding a duplicate widget
------------------------------------------
Key: RAVE-332
URL: https://issues.apache.org/jira/browse/RAVE-332
Project: Rave
Issue Type: Sub-task
Reporter: Jasha Joachimsthal
Assignee: Jasha Joachimsthal
Priority: Minor
The Validator can reject the new widget if its url is already present.
Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Jasha Joachimsthal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated RAVE-332:
------------------------------------
Issue Type: Improvement (was: Sub-task)
Parent: (was: RAVE-331)
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Improvement
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
> Attachments: RAVE-332_move_check_for_existing_widget_from_the_service_to_the_validator.patch
>
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Jasha Joachimsthal (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal resolved RAVE-332.
-------------------------------------
Resolution: Fixed
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Improvement
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
> Attachments: RAVE-332_move_check_for_existing_widget_from_the_service_to_the_validator.patch
>
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Jasha Joachimsthal (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jasha Joachimsthal updated RAVE-332:
------------------------------------
Attachment: RAVE-332_move_check_for_existing_widget_from_the_service_to_the_validator.patch
Patch to move the responsibility of the duplicate widget to the validator. Does not include required description yet.
Waits for permission fix in RAVE-331.
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Sub-task
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
> Attachments: RAVE-332_move_check_for_existing_widget_from_the_service_to_the_validator.patch
>
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141251#comment-13141251 ]
Jasha Joachimsthal commented on RAVE-332:
-----------------------------------------
Then the admin is suddenly responsible for a gadget name. I don't mind having duplicate names, otherwise you get names like "Calendar", "Calendar2", "Cool calendar". There are enough options to distinguish them (description, thumbnail, screenshot).
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Sub-task
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Marlon Pierce (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141253#comment-13141253 ]
Marlon Pierce commented on RAVE-332:
------------------------------------
Then I suggest making description required.
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Sub-task
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Marlon Pierce (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141245#comment-13141245 ]
Marlon Pierce commented on RAVE-332:
------------------------------------
Should widgets be allowed to have the same name? Currently they can, but this could be confusing. The alternative could be to prevent the reuse of a gadget name for all approved gadgets. Gadgets pending approval could have duplicate names.
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Sub-task
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-332) Change logic of adding a duplicate
widget
Posted by "Jasha Joachimsthal (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141279#comment-13141279 ]
Jasha Joachimsthal commented on RAVE-332:
-----------------------------------------
Good suggestion :)
> Change logic of adding a duplicate widget
> ------------------------------------------
>
> Key: RAVE-332
> URL: https://issues.apache.org/jira/browse/RAVE-332
> Project: Rave
> Issue Type: Sub-task
> Reporter: Jasha Joachimsthal
> Assignee: Jasha Joachimsthal
> Priority: Minor
>
> The Validator can reject the new widget if its url is already present.
> Then if for some reason DefaultWidgetService#registerNewWidget is called for a URL that already exists, it can throw a (DuplicateItem)Exception instead of returning null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira