[GitHub] [skywalking-java] xiaqi1210 commented on pull request #603: Fix the issue of createSpan failure caused by invalid request URL in HttpClient 4.x/5.x plugin

["xiaqi1210 (via GitHub)" <gi...@apache.org>]

xiaqi1210 commented on PR #603:
URL: https://github.com/apache/skywalking-java/pull/603#issuecomment-1702320631

   > Can't we use some methods to check this but have to use `try/catch`? This is not a good practice in Java agent. Another thing is, shouldn't we use `/` instead of the whole URL? After all, span name should be URI rather then URL, which may not be friendly in statistics.
   
   Is not using try/catch considered for performance? What I can think of is that I can use substring to get the content after the first "/" after "://" in the URL as the URI. If I can't get it, the default is "/". What do you think of this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org