You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/12/04 04:41:28 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6753: NIFI-10941 Remove TestNG references

exceptionfactory opened a new pull request, #6753:
URL: https://github.com/apache/nifi/pull/6753

   # Summary
   
   [NIFI-10941](https://issues.apache.org/jira/browse/NIFI-10941) Removes all references to TestNG assertions and dependencies. Several test classes had inadvertent references to TestNG assertions, which should be using JUnit, and several Toolkit modules included TestNG dependencies through Groovy.
   
   Changes include refactoring impacted tests to use JUnit 5 and adding TestNG to the list of banned dependencies.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [ ] JDK 11
     - [ ] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] dan-s1 commented on pull request #6753: NIFI-10941 Remove TestNG references

Posted by GitBox <gi...@apache.org>.
dan-s1 commented on PR #6753:
URL: https://github.com/apache/nifi/pull/6753#issuecomment-1349646454

   @exceptionfactory I see ImportFlowIt on line 59 still has 
   
   `import org.junit.Test;
   `
   instead of 
   
   `import org.junit.jupiter.api.Test;`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] asfgit closed pull request #6753: NIFI-10941 Remove TestNG references

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #6753: NIFI-10941 Remove TestNG references
URL: https://github.com/apache/nifi/pull/6753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org