You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/15 12:50:56 UTC

[GitHub] [incubator-nuttx] gustavonihei commented on a change in pull request #4550: ESP32C3 PWM Driver fix && LCD Drivers

gustavonihei commented on a change in pull request #4550:
URL: https://github.com/apache/incubator-nuttx/pull/4550#discussion_r709153294



##########
File path: arch/risc-v/src/esp32c3/Kconfig
##########
@@ -261,6 +262,29 @@ config ESP32C3_SPIFLASH
 	select MTD_BYTE_WRITE
 	select MTD_PARTITION
 
+config ESP32C3_SPI_LCD
+	bool "Generic SPI LCD Module"
+	default n
+	select ESP32C3_SPI2
+	select SPI_CMDDATA
+	select ESP32C3_SPI_SWCS
+	select SPI_SWAPBYTES
+
+if ESP32C3_SPI_LCD
+
+config SPI_SWAPBYTES
+	bool "Swap high and low bytes during 16bit SPI send"

Review comment:
       Shouldn't this swapping be performed at application-level?
   See that LVGL has an option for this:
   
   https://github.com/apache/incubator-nuttx-apps/blob/master/graphics/lvgl/Kconfig#L119-L122




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org