You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "mridulpathak (via GitHub)" <gi...@apache.org> on 2026/10/03 17:47:00 UTC
[PR] Fixed: Do not evaluate a request parameter as an expression in the return-user-message from-field (OFBIZ-13640) [ofbiz-framework]
mridulpathak opened a new pull request, #2193:
URL: https://github.com/apache/ofbiz-framework/pull/2193
Fixed: Do not evaluate a request parameter as an expression in the return-user-message from-field (OFBIZ-13640)
Explanation:
With return-user-message from-field in a controller, RequestHandler.setUserMessageResponseToRequest looked the field up in the combined map of the request, where the request parameters are the fallback when no attribute with that name exists, and evaluated the value as a FlexibleStringExpander, so a request parameter with the name of the field was evaluated as an expression, while a message that comes from the request through _CUSTOM_ERROR_MESSAGE_ or _CUSTOM_EVENT_MESSAGE_ is deliberately not expanded.
The field is now read from the request attributes only, which is where the results of events and services are, so request parameters are never evaluated, and the documentation of from-field in site-conf.xsd says so. No controller delivered with OFBiz uses return-user-message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed: Do not evaluate a request parameter as an expression in the return-user-message from-field (OFBIZ-13640) [ofbiz-framework]
Posted by "mridulpathak (via GitHub)" <gi...@apache.org>.
mridulpathak merged PR #2193:
URL: https://github.com/apache/ofbiz-framework/pull/2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org