You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@orc.apache.org by do...@apache.org on 2021/08/14 06:08:44 UTC

[orc] branch main updated: ORC-945: Add OUTPUT_QUIET, ERROR_QUIET to suppress Java8 addopen error messages (#858)

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/orc.git


The following commit(s) were added to refs/heads/main by this push:
     new 6840cd6  ORC-945: Add OUTPUT_QUIET, ERROR_QUIET to suppress Java8 addopen error messages (#858)
6840cd6 is described below

commit 6840cd65a8986f2fe63e78dad4c6b10c825c8e6a
Author: William Hyun <wi...@apache.org>
AuthorDate: Fri Aug 13 23:08:39 2021 -0700

    ORC-945: Add OUTPUT_QUIET, ERROR_QUIET to suppress Java8 addopen error messages (#858)
    
    ### What changes were proposed in this pull request?
    This PR aims to add `OUTPUT_QUIET` and `ERROR_QUIET` to suppress Java8 `add-open` error messages
    
    ### Why are the changes needed?
    Error messages could be misleading, so we had better suppress it.
    - https://github.com/apache/orc/runs/3324055264
    ```
    Unrecognized option: --add-opens
    Error: Could not create the Java Virtual Machine.
    Error: A fatal exception has occurred. Program will exit.
    ```
    
    ### How was this patch tested?
    Check the GHA logs on this PR.
---
 java/CMakeLists.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/java/CMakeLists.txt b/java/CMakeLists.txt
index 130134b..c39f1f5 100644
--- a/java/CMakeLists.txt
+++ b/java/CMakeLists.txt
@@ -67,7 +67,9 @@ add_test(
 execute_process(
   COMMAND java --add-opens java.base/java.nio=ALL-UNNAMED -version
   WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}
-  RESULT_VARIABLE RET)
+  RESULT_VARIABLE RET
+  OUTPUT_QUIET
+  ERROR_QUIET)
 if(RET EQUAL 0)
   set(ADD_OPENS --add-opens)
   set(JAVA_NIO java.base/java.nio=ALL-UNNAMED)