[GitHub] [solr] noblepaul commented on a diff in pull request #1258: Refactoring to move live nodes handling out of ZkStateReader and into own class

[GitBox <gi...@apache.org>]

noblepaul commented on code in PR #1258:
URL: https://github.com/apache/solr/pull/1258#discussion_r1059698710


##########
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java:
##########
@@ -105,7 +104,6 @@ public class ZkStateReader implements SolrCloseable {
   public static final String MAX_WAIT_SECONDS_PROP = "maxWaitSeconds";
   public static final String STATE_TIMESTAMP_PROP = "stateTimestamp";
   public static final String COLLECTIONS_ZKNODE = "/collections";
-  public static final String LIVE_NODES_ZKNODE = "/live_nodes";

Review Comment:
   It's backward incompatible to remove this public static variable. May be we can deprecate this and remove later 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org