You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "zhang-arvin (via GitHub)" <gi...@apache.org> on 2026/08/18 16:13:27 UTC

[PR] [Improve][Connector-V2] Remove redundant imperative validation in Doris connector [seatunnel]

zhang-arvin opened a new pull request, #11858:
URL: https://github.com/apache/seatunnel/pull/11858

   ## Purpose
   
   Remove redundant imperative validation in Doris connector that is already covered by declarative `optionRule()`.
   
   ## Changes
   
   | File | Change |
   |------|--------|
   | `DorisSinkConfig.java` | Remove `validate()` method and `validateDirectWriteOptions()` method |
   | `DorisSinkFactory.java` | Remove `DorisSinkConfig.validate(config)` call from `createSink()` |
   
   ## Context
   
   Part of the OptionRule migration umbrella (#11007). The `optionRule()` in `DorisSinkFactory` already has:
   ```java
   .conditional(DorisSinkOptions.DIRECT_TO_BE, true, DorisSinkOptions.BENODES)
   ```
   
   This declaratively enforces the same constraint that `validateDirectWriteOptions()` was doing imperatively. The declarative check runs at `--check` time, making it more useful than the runtime-only imperative check.
   
   Closes #11007 (Doris connector row)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improve][Connector-V2] Remove redundant imperative validation in Doris connector [seatunnel]

Posted by "davidzollo (via GitHub)" <gi...@apache.org>.
davidzollo merged PR #11858:
URL: https://github.com/apache/seatunnel/pull/11858


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org