You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/07 18:58:09 UTC

[GitHub] GJL opened a new pull request #7666: [FLINK-11548][tests] Delete test ClusterShutdownITCase

GJL opened a new pull request #7666: [FLINK-11548][tests] Delete test ClusterShutdownITCase
URL: https://github.com/apache/flink/pull/7666
 
 
   ## What is the purpose of the change
   
   *This deletes the test `ClusterShutdownITCase`. The test was asserting that the `StopCluster` message is sent to the _TMs_ and _RM_ by the _JobManager_. In FLIP-6 mode, the _TMs_ are not actively shut down by the Dispatcher. However, there are related things that can be tested:*
   
     1. *The Dispatcher should terminate after job completion in a per-job cluster (`MiniDispatcher#testTerminationAfterJobCompletion`).*
     1. *The Dispatcher should terminate when it is shut down via the REST API (`DispatcherTest#testShutDownClusterShouldTerminateDispatcher`).*
   
   
   ## Brief change log
   
     - *Delete test `ClusterShutdownITCase`*
     - *Add test `DispatcherTest#testShutDownClusterShouldTerminateDispatcher`*
   
   ## Verifying this change
   
   - Run `DispatcherTest#testShutDownClusterShouldTerminateDispatcher`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services