You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/05/20 14:07:58 UTC

[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1279: TINKERPOP-2288 Replace closed connections directly

jorgebay commented on a change in pull request #1279:
URL: https://github.com/apache/tinkerpop/pull/1279#discussion_r428037978



##########
File path: docs/src/reference/gremlin-variants.asciidoc
##########
@@ -1090,10 +1090,13 @@ on the `ConnectionPoolSettings` instance that can be passed to the `GremlinClien
 |Key |Description |Default
 |PoolSize |The size of the connection pool. |4
 |MaxInProcessPerConnection |The maximum number of in-flight requests that can occur on a connection. |32
+|GetOpenConnectionRetries |The number of retries to get an open connection from the pool to submit a request. |4

Review comment:
       NIT: Maybe we could use `GetReconnectionAttempts()` as a name?
   
   Instead of a number, it could return an `IEnumerable<int>`, that represents milliseconds to wait between each attempt.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org