You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/10/09 12:48:27 UTC
[GitHub] stevedlawrence opened a new pull request #124: Check for available
data before trying to parse binarySeconds or binaryMilliseconds
stevedlawrence opened a new pull request #124: Check for available data before trying to parse binarySeconds or binaryMilliseconds
URL: https://github.com/apache/incubator-daffodil/pull/124
If we do not check for available data, a NotEnoughData exception is
thrown when trying to get the binary long, which ends up leaking.
Instead, we should just check for enough data first.
Also, when exceptions are accidentally leaked, ensure that we discard
marks before throwing an assertion about the leak. Otherwise the mark is
never returned and we get an error about leaked marks instead of the
actual root issue of a leaked assertion.
DAFFODIL-2010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services