You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "nfrankel (via GitHub)" <gi...@apache.org> on 2023/05/16 19:07:46 UTC

[GitHub] [shardingsphere] nfrankel opened a new pull request, #25716: doc: Fix the documentation for configuring ShardingSphere with an absolute path

nfrankel opened a new pull request, #25716:
URL: https://github.com/apache/shardingsphere/pull/25716

   Changes proposed in this pull request:
   
   The current documentation mentions:
   
   >Load JDBC URL of config.yaml profile in absolute path
   >
   >`jdbc:shardingsphere:/path/to/config.yaml`
   
   However, the [code](https://github.com/apache/shardingsphere/blob/955ea40a41f083529ce2b98cd239a16d984ffe4a/jdbc/core/src/main/java/org/apache/shardingsphere/driver/jdbc/core/driver/spi/AbsolutePathDriverURLProvider.java#L38-L43) is clear) tells a different story. It needs to be prefixed with `jdbc:shardingsphere:absolutepath:`
   
   Hence, the change is:
   
   >Load JDBC URL of config.yaml profile in absolute path
   >
   >`jdbc:shardingsphere:absolutepath:/path/to/config.yaml`
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [X] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [X] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [X] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 commented on pull request #25716: doc: Fix the documentation for configuring ShardingSphere with an absolute path

Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 commented on PR #25716:
URL: https://github.com/apache/shardingsphere/pull/25716#issuecomment-1556155427

   @Pace2Car Hi, can you review it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] Pace2Car commented on pull request #25716: doc: Fix the documentation for configuring ShardingSphere with an absolute path

Posted by "Pace2Car (via GitHub)" <gi...@apache.org>.
Pace2Car commented on PR #25716:
URL: https://github.com/apache/shardingsphere/pull/25716#issuecomment-1556440340

   Hi @nfrankel, Thanks for your careful pointing out that this is indeed an omission in the documentation.
   
   I have accepted these updates, please @zhaojinchao95 merge into master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] zhaojinchao95 merged pull request #25716: doc: Fix the documentation for configuring ShardingSphere with an absolute path

Posted by "zhaojinchao95 (via GitHub)" <gi...@apache.org>.
zhaojinchao95 merged PR #25716:
URL: https://github.com/apache/shardingsphere/pull/25716


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org