You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/03/07 00:52:07 UTC
[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support
Hello David Ribeiro Alves, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9521
to review the following change.
Change subject: env: generalize resource limits and add RLIMIT_NPROC support
......................................................................
env: generalize resource limits and add RLIMIT_NPROC support
A follow-on patch will use this to cap the max number of threads in some
process-wide thread pools (see KUDU-1913).
Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
---
M src/kudu/fs/block_manager.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
5 files changed, 100 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/9521/1
--
To view, visit http://gerrit.cloudera.org:8080/9521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Gerrit-Change-Number: 9521
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9521 )
Change subject: env: generalize resource limits and add RLIMIT_NPROC support
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env-test.cc@675
PS1, Line 675: KUDU-1798.
hum was the number of the jira wrong?
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env.h
File src/kudu/util/env.h:
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env.h@319
PS1, Line 319: RUNNING_THREADS
hum, technically RLIMIT_NPROC is the limit of the total number of processes that can run for a user, not the total number of threads a process can run. yes that translates to almost the same thing when kudu is run with its own user, but wondering if conflating the two isn't confusing...
--
To view, visit http://gerrit.cloudera.org:8080/9521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Gerrit-Change-Number: 9521
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Mar 2018 01:25:44 +0000
Gerrit-HasComments: Yes
[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support
Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/9521 )
Change subject: env: generalize resource limits and add RLIMIT_NPROC support
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Gerrit-Change-Number: 9521
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Mar 2018 21:44:00 +0000
Gerrit-HasComments: No
[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello David Ribeiro Alves, Kudu Jenkins, Todd Lipcon,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9521
to look at the new patch set (#2).
Change subject: env: generalize resource limits and add RLIMIT_NPROC support
......................................................................
env: generalize resource limits and add RLIMIT_NPROC support
A follow-on patch will use this to cap the max number of threads in some
process-wide thread pools (see KUDU-1913).
Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
---
M src/kudu/fs/block_manager.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
5 files changed, 106 insertions(+), 33 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/21/9521/2
--
To view, visit http://gerrit.cloudera.org:8080/9521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Gerrit-Change-Number: 9521
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/9521 )
Change subject: env: generalize resource limits and add RLIMIT_NPROC support
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env-test.cc
File src/kudu/util/env-test.cc:
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env-test.cc@675
PS1, Line 675: KUDU-1798.
> hum was the number of the jira wrong?
Yes, the original number was wrong. This is the correct JIRA.
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env.h
File src/kudu/util/env.h:
http://gerrit.cloudera.org:8080/#/c/9521/1/src/kudu/util/env.h@319
PS1, Line 319: RUNNING_THREADS
> hum, technically RLIMIT_NPROC is the limit of the total number of processes
That's a good point; I'll clarify these.
--
To view, visit http://gerrit.cloudera.org:8080/9521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Gerrit-Change-Number: 9521
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Wed, 07 Mar 2018 21:01:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] env: generalize resource limits and add RLIMIT NPROC support
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9521 )
Change subject: env: generalize resource limits and add RLIMIT_NPROC support
......................................................................
env: generalize resource limits and add RLIMIT_NPROC support
A follow-on patch will use this to cap the max number of threads in some
process-wide thread pools (see KUDU-1913).
Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Reviewed-on: http://gerrit.cloudera.org:8080/9521
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
Tested-by: Kudu Jenkins
---
M src/kudu/fs/block_manager.cc
M src/kudu/rpc/rpc-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
5 files changed, 106 insertions(+), 33 deletions(-)
Approvals:
David Ribeiro Alves: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9521
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I567f581a6f8a85ac1f08878b61ac316cc2da36a0
Gerrit-Change-Number: 9521
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>