You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "rmcdouga (via GitHub)" <gi...@apache.org> on 2023/11/06 22:08:49 UTC
[PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
rmcdouga opened a new pull request, #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2
Moved assertThat in tests over to Hamcrest's assertThat. Moved from deprecated IsCollectionContaining to IsIterableContaining in MapUtil. Addressed some type warnings by adding types to untyped generics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1802381013
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list) [85.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rmcdouga (via GitHub)" <gi...@apache.org>.
rmcdouga commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803926586
Thank you for doing that and walking me through the process. I will structure my commit comments like that in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "jsedding (via GitHub)" <gi...@apache.org>.
jsedding commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1798200265
Maybe you can just delegate to [`FrameworkUtil.asMap()`](https://github.com/apache/felix-dev/blob/6eda79100676b63c1221c2d87416b286f028f952/framework/src/main/java/org/osgi/framework/FrameworkUtil.java#L718) to cover the `Dictionary` case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1796977008
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list) [33.3% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1798677629
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list) [85.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rmcdouga (via GitHub)" <gi...@apache.org>.
rmcdouga commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1796858810
The build failure was not in a file I changed. The line in question uses the <tt> tag in a JavaDoc comment. The JavaDoc compiler says that this tag is unsupported in this version of HTML.
Should I change the files to use {@code} instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803933132
All good, thanks for the contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "henrykuijpers (via GitHub)" <gi...@apache.org>.
henrykuijpers commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797852858
@rmcdouga That is indeed an infinite loop. Nicely spotted! Given that this whole thing would really boil down to a thing in very old (unsupported) jdk versions and given that Dictionary should not be used anymore (however, it is still being used in OSGi!), it can be safely removed. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rmcdouga (via GitHub)" <gi...@apache.org>.
rmcdouga commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1798778762
> Maybe you can just delegate to [FrameworkUtil.asMap()](https://github.com/apache/felix-dev/blob/6eda79100676b63c1221c2d87416b286f028f952/framework/src/main/java/org/osgi/framework/FrameworkUtil.java#L718) to cover the Dictionary case?
I went back and looked into using FrameworkUtil. It would require adding another dependency (org.osgi.core is currently a test only dependency). I'm hesitant to add the dependency to accomodate what would inevitably be newly developed client code (old client code would generate the Stack Overflow, so we know there's no code out there today that passes in a custom Dictionary).
My feeling is that we should not be facilitating the use of Dictionary in new code, so I don't feel bad if we force the developer to use FrameworkUtil to convert the Dictionary to a Map before passing the object into us.
One last thing to keep in mind is that this only affects Dictionary objects that *do not* implement the Map interface. I'm not sure how many are in the OSGi framework, but the one implementation in the JDK (HashTable) does implement Map, so I think this is a rare case that I don't feel bad about requiring a little extra work on the developer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1803763338
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list) [85.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rmcdouga (via GitHub)" <gi...@apache.org>.
rmcdouga commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797023577
There's a serious issue in the MapUtils code. The code tries to handle a Dictionary object but does so poorly (generates a StackOverflow error).
Now it turns out this wasn't caught before because Dictionary is an abstract class with only one subclass in the JDK (HashTable). HashTable implements Map, so Hashtables don't ever make it down to the Dictionary-specific code. The only code that will make it down there is a custom subclass of Dictionary.
Given how old and unused Dictionary is (it was replaced by Map in JDK 1.2), I think it's safe to remove the section of code that tries (unsuccessfully) to deal with Dictionary subclasses, but I would like to verify that this is OK with a committer before I do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rombert (via GitHub)" <gi...@apache.org>.
rombert merged PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1797018177
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list) [66.7% Coverage](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-testing-hamcrest&pullRequest=2&metric=new_duplicated_lines_density&view=list)
 Catch issues before they fail your Quality Gate with our IDE extension  [SonarLint](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=sonarcloud-welcome)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Updated Hamcrest version to 2.2 [sling-org-apache-sling-testing-hamcrest]
Posted by "rmcdouga (via GitHub)" <gi...@apache.org>.
rmcdouga commented on PR #2:
URL: https://github.com/apache/sling-org-apache-sling-testing-hamcrest/pull/2#issuecomment-1801999485
OK, will do. I have some other tasks at work, so it may not happen until the weekend.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org