You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gengliangwang <gi...@git.apache.org> on 2017/07/05 23:50:15 UTC
[GitHub] spark pull request #18549: rename plans.logical.statsEstimation.Range to Val...
GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/18549
rename plans.logical.statsEstimation.Range to ValueInterval
## What changes were proposed in this pull request?
Rename org.apache.spark.sql.catalyst.plans.logical.statsEstimation.Range to ValueInterval.
The current naming is identical to logical operator "range".
Refactoring it to ValueInterval is more accurate.
## How was this patch tested?
unit test
Please review http://spark.apache.org/contributing.html before opening a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark ValueInterval
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/18549.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #18549
----
commit 80b1a7449b6e106b4448ddb9d4f725d08289fa8f
Author: Wang Gengliang <lt...@gmail.com>
Date: 2017-07-05T23:39:22Z
renmae org.apache.spark.sql.catalyst.plans.logical.statsEstimation.Range to ValueInterval
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79250/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18549
cc @rxin @gatorsmile
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79261/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79252 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79252/testReport)** for PR 18549 at commit [`6e52a69`](https://github.com/apache/spark/commit/6e52a690885e15ba9eceb3d18b75b31726180f91).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79261 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79261/testReport)** for PR 18549 at commit [`b51ab80`](https://github.com/apache/spark/commit/b51ab80a68f2d528911d82a244b6ba5e9169b29c).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/18549
Merging in master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstim...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on a diff in the pull request:
https://github.com/apache/spark/pull/18549#discussion_r125811566
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/ValueInterval.scala ---
@@ -38,46 +38,49 @@ case class NumericRange(min: Decimal, max: Decimal) extends Range {
* This version of Spark does not have min/max for binary/string types, we define their default
* behaviors by this class.
*/
-class DefaultRange extends Range {
+class DefaultValueInterval extends ValueInterval {
override def contains(l: Literal): Boolean = true
}
/** This is for columns with only null values. */
-class NullRange extends Range {
+class NullValueInterval extends ValueInterval {
override def contains(l: Literal): Boolean = false
}
-object Range {
- def apply(min: Option[Any], max: Option[Any], dataType: DataType): Range = dataType match {
- case StringType | BinaryType => new DefaultRange()
- case _ if min.isEmpty || max.isEmpty => new NullRange()
+object ValueInterval {
+ def apply(
+ min: Option[Any],
+ max: Option[Any],
+ dataType: DataType): ValueInterval = dataType match {
+ case StringType | BinaryType => new DefaultValueInterval()
+ case _ if min.isEmpty || max.isEmpty => new NullValueInterval()
case _ =>
- NumericRange(
+ NumericValueInterval(
min = EstimationUtils.toDecimal(min.get, dataType),
max = EstimationUtils.toDecimal(max.get, dataType))
}
- def isIntersected(r1: Range, r2: Range): Boolean = (r1, r2) match {
- case (_, _: DefaultRange) | (_: DefaultRange, _) =>
+ def isIntersected(r1: ValueInterval, r2: ValueInterval): Boolean = (r1, r2) match {
+ case (_, _: DefaultValueInterval) | (_: DefaultValueInterval, _) =>
// The DefaultRange represents string/binary types which do not have max/min stats,
--- End diff --
Thanks, I have fixed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79266 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79266/testReport)** for PR 18549 at commit [`b51ab80`](https://github.com/apache/spark/commit/b51ab80a68f2d528911d82a244b6ba5e9169b29c).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: rename plans.logical.statsEstimation.Range to ValueInter...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79250 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79250/testReport)** for PR 18549 at commit [`80b1a74`](https://github.com/apache/spark/commit/80b1a7449b6e106b4448ddb9d4f725d08289fa8f).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79266 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79266/testReport)** for PR 18549 at commit [`b51ab80`](https://github.com/apache/spark/commit/b51ab80a68f2d528911d82a244b6ba5e9169b29c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstim...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/18549#discussion_r125811134
--- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/ValueInterval.scala ---
@@ -38,46 +38,49 @@ case class NumericRange(min: Decimal, max: Decimal) extends Range {
* This version of Spark does not have min/max for binary/string types, we define their default
* behaviors by this class.
*/
-class DefaultRange extends Range {
+class DefaultValueInterval extends ValueInterval {
override def contains(l: Literal): Boolean = true
}
/** This is for columns with only null values. */
-class NullRange extends Range {
+class NullValueInterval extends ValueInterval {
override def contains(l: Literal): Boolean = false
}
-object Range {
- def apply(min: Option[Any], max: Option[Any], dataType: DataType): Range = dataType match {
- case StringType | BinaryType => new DefaultRange()
- case _ if min.isEmpty || max.isEmpty => new NullRange()
+object ValueInterval {
+ def apply(
+ min: Option[Any],
+ max: Option[Any],
+ dataType: DataType): ValueInterval = dataType match {
+ case StringType | BinaryType => new DefaultValueInterval()
+ case _ if min.isEmpty || max.isEmpty => new NullValueInterval()
case _ =>
- NumericRange(
+ NumericValueInterval(
min = EstimationUtils.toDecimal(min.get, dataType),
max = EstimationUtils.toDecimal(max.get, dataType))
}
- def isIntersected(r1: Range, r2: Range): Boolean = (r1, r2) match {
- case (_, _: DefaultRange) | (_: DefaultRange, _) =>
+ def isIntersected(r1: ValueInterval, r2: ValueInterval): Boolean = (r1, r2) match {
+ case (_, _: DefaultValueInterval) | (_: DefaultValueInterval, _) =>
// The DefaultRange represents string/binary types which do not have max/min stats,
--- End diff --
`DefaultRange` -> `DefaultValueInterval `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79266/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by gatorsmile <gi...@git.apache.org>.
Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/18549
LGTM except one minor comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by gengliangwang <gi...@git.apache.org>.
Github user gengliangwang commented on the issue:
https://github.com/apache/spark/pull/18549
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79261 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79261/testReport)** for PR 18549 at commit [`b51ab80`](https://github.com/apache/spark/commit/b51ab80a68f2d528911d82a244b6ba5e9169b29c).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstim...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/18549
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79252 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79252/testReport)** for PR 18549 at commit [`6e52a69`](https://github.com/apache/spark/commit/6e52a690885e15ba9eceb3d18b75b31726180f91).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/18549
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/79252/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #18549: [SPARK-21323][SQL]Rename plans.logical.statsEstimation.R...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/18549
**[Test build #79250 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/79250/testReport)** for PR 18549 at commit [`80b1a74`](https://github.com/apache/spark/commit/80b1a7449b6e106b4448ddb9d4f725d08289fa8f).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org