You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/13 03:44:02 UTC
[GitHub] [spark] Ngone51 opened a new pull request #27556: [SPARK-25990]
ScriptTransform should handle different data types correctly
Ngone51 opened a new pull request #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
We should convert Spark InternalRows to hive data via `HiveInspectors.wrapperFor`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
We may hit below exception without this change:
```
[info] org.apache.spark.SparkException: Job aborted due to stage failure: Task 0 in stage 1.0 failed 1 times, most recent failure: Lost task 0.0 in stage 1.0 (TID 1, 192.168.1.6, executor driver): java.lang.ClassCastException: org.apache.spark.sql.types.Decimal cannot be cast to org.apache.hadoop.hive.common.type.HiveDecimal
[info] at org.apache.hadoop.hive.serde2.objectinspector.primitive.JavaHiveDecimalObjectInspector.getPrimitiveJavaObject(JavaHiveDecimalObjectInspector.java:55)
[info] at org.apache.hadoop.hive.serde2.lazy.LazyUtils.writePrimitiveUTF8(LazyUtils.java:321)
[info] at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serialize(LazySimpleSerDe.java:292)
[info] at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.serializeField(LazySimpleSerDe.java:247)
[info] at org.apache.hadoop.hive.serde2.lazy.LazySimpleSerDe.doSerialize(LazySimpleSerDe.java:231)
[info] at org.apache.hadoop.hive.serde2.AbstractEncodingAwareSerDe.serialize(AbstractEncodingAwareSerDe.java:55)
[info] at org.apache.spark.sql.hive.execution.ScriptTransformationWriterThread.$anonfun$run$2(ScriptTransformationExec.scala:300)
[info] at org.apache.spark.sql.hive.execution.ScriptTransformationWriterThread.$anonfun$run$2$adapted(ScriptTransformationExec.scala:281)
[info] at scala.collection.Iterator.foreach(Iterator.scala:941)
[info] at scala.collection.Iterator.foreach$(Iterator.scala:941)
[info] at scala.collection.AbstractIterator.foreach(Iterator.scala:1429)
[info] at org.apache.spark.sql.hive.execution.ScriptTransformationWriterThread.$anonfun$run$1(ScriptTransformationExec.scala:281)
[info] at scala.runtime.java8.JFunction0$mcV$sp.apply(JFunction0$mcV$sp.java:23)
[info] at org.apache.spark.util.Utils$.logUncaughtExceptions(Utils.scala:1932)
[info] at org.apache.spark.sql.hive.execution.ScriptTransformationWriterThread.run(ScriptTransformationExec.scala:270)
```
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added new test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586077056
Jenkins, retest this please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585571830
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-602312532
> Dose your pr make transform support array/map datatype as script's input column?
@AngersZhuuuu No. This doesn't add support for new types but just improve already supported types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585571830
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586117962
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990] ScriptTransform should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585536493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23091/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-602044167
@Ngone51
Dose your pr make transform support array/map datatype as script's input column?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#discussion_r378937849
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
##########
@@ -186,6 +191,43 @@ class ScriptTransformationSuite extends SparkPlanTest with TestHiveSingleton wit
rowsDf.select("name").collect())
assert(uncaughtExceptionHandler.exception.isEmpty)
}
+
+ test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+ assume(TestUtils.testCommandAvailable("python"))
+ val scriptFilePath = getTestResourcePath("test_script.py")
+
+ withTempView("v") {
+ val df = Seq(
+ (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1)),
+ (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2)),
+ (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3))
+ ).toDF("a", "b", "c", "d", "e") // Note column d's data type is Decimal(38, 18)
+ df.createTempView("v")
+
+ val query = sql(
+ s"""
+ |SELECT
+ |TRANSFORM(a, b, c, d, e)
+ |USING 'python $scriptFilePath' AS (a, b, c, d, e)
+ |FROM v
+ """.stripMargin)
+
+ // In Hive1.2, it does not do well on Decimal conversion. For example, in this case,
+ // it converts a decimal value's type from Decimal(38, 18) to Decimal(1, 0). So we need
Review comment:
This is a little confusing, if Hive 1.2 uses `Decimal(1, 0)` as the type, then `cast("decimal(1, 0)")` should be a no-op?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#discussion_r378824280
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
##########
@@ -186,6 +191,40 @@ class ScriptTransformationSuite extends SparkPlanTest with TestHiveSingleton wit
rowsDf.select("name").collect())
assert(uncaughtExceptionHandler.exception.isEmpty)
}
+
+ test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+ assume(TestUtils.testCommandAvailable("python"))
+ val scriptFilePath = getTestResourcePath("test_script.py")
+
+ withTempView("v") {
+ val df = Seq(
+ (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1)),
+ (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2)),
+ (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3))
+ ).toDF("a", "b", "c", "d", "e")
+ df.createTempView("v")
+
+ val query = sql(
+ s"""
+ |SELECT
+ |TRANSFORM(a, b, c, d, e)
+ |USING 'python $scriptFilePath' AS (a, b, c, d, e)
+ |FROM v
+ """.stripMargin)
+
+ val castDecimal: Column => Column = if (HiveUtils.isHive23) {
Review comment:
and maybe name it as `decimalToString`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586117967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118389/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Ngone51 commented on issue #27556: [SPARK-25990]
ScriptTransform should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
Ngone51 commented on issue #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585549946
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585821829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23127/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586117967
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118389/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#discussion_r378824134
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
##########
@@ -186,6 +191,40 @@ class ScriptTransformationSuite extends SparkPlanTest with TestHiveSingleton wit
rowsDf.select("name").collect())
assert(uncaughtExceptionHandler.exception.isEmpty)
}
+
+ test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+ assume(TestUtils.testCommandAvailable("python"))
+ val scriptFilePath = getTestResourcePath("test_script.py")
+
+ withTempView("v") {
+ val df = Seq(
+ (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1)),
+ (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2)),
+ (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3))
+ ).toDF("a", "b", "c", "d", "e")
+ df.createTempView("v")
+
+ val query = sql(
+ s"""
+ |SELECT
+ |TRANSFORM(a, b, c, d, e)
+ |USING 'python $scriptFilePath' AS (a, b, c, d, e)
+ |FROM v
+ """.stripMargin)
+
+ val castDecimal: Column => Column = if (HiveUtils.isHive23) {
Review comment:
can we add some code comments to explain it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586117962
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586079152
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27556: [SPARK-25990]
ScriptTransform should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585536232
**[Test build #118334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118334/testReport)** for PR 27556 at commit [`5a176b3`](https://github.com/apache/spark/commit/5a176b3c907f56e2ba2c4fc104626e05ec4738b1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990] ScriptTransform should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585536489
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990]
ScriptTransform should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585536489
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585821829
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23127/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585820986
**[Test build #118370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118370/testReport)** for PR 27556 at commit [`a07ccff`](https://github.com/apache/spark/commit/a07ccff741ddde10ee4aa522534db62df08ce72e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586079154
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23146/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585892301
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118370/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586078522
**[Test build #118389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118389/testReport)** for PR 27556 at commit [`a07ccff`](https://github.com/apache/spark/commit/a07ccff741ddde10ee4aa522534db62df08ce72e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#discussion_r378937849
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
##########
@@ -186,6 +191,43 @@ class ScriptTransformationSuite extends SparkPlanTest with TestHiveSingleton wit
rowsDf.select("name").collect())
assert(uncaughtExceptionHandler.exception.isEmpty)
}
+
+ test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+ assume(TestUtils.testCommandAvailable("python"))
+ val scriptFilePath = getTestResourcePath("test_script.py")
+
+ withTempView("v") {
+ val df = Seq(
+ (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1)),
+ (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2)),
+ (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3))
+ ).toDF("a", "b", "c", "d", "e") // Note column d's data type is Decimal(38, 18)
+ df.createTempView("v")
+
+ val query = sql(
+ s"""
+ |SELECT
+ |TRANSFORM(a, b, c, d, e)
+ |USING 'python $scriptFilePath' AS (a, b, c, d, e)
+ |FROM v
+ """.stripMargin)
+
+ // In Hive1.2, it does not do well on Decimal conversion. For example, in this case,
+ // it converts a decimal value's type from Decimal(38, 18) to Decimal(1, 0). So we need
Review comment:
This is a little confusing, if Hive 1.2 uses `Decimal(1, 0)` as the type, then `cast("decimal(1, 0)")` should be a no-op?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585821814
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585892294
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585821814
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586117360
**[Test build #118389 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118389/testReport)** for PR 27556 at commit [`a07ccff`](https://github.com/apache/spark/commit/a07ccff741ddde10ee4aa522534db62df08ce72e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586160626
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585892294
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#discussion_r378938183
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
##########
@@ -186,6 +191,43 @@ class ScriptTransformationSuite extends SparkPlanTest with TestHiveSingleton wit
rowsDf.select("name").collect())
assert(uncaughtExceptionHandler.exception.isEmpty)
}
+
+ test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+ assume(TestUtils.testCommandAvailable("python"))
+ val scriptFilePath = getTestResourcePath("test_script.py")
+
+ withTempView("v") {
+ val df = Seq(
+ (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1)),
+ (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2)),
+ (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3))
+ ).toDF("a", "b", "c", "d", "e") // Note column d's data type is Decimal(38, 18)
+ df.createTempView("v")
+
+ val query = sql(
+ s"""
+ |SELECT
+ |TRANSFORM(a, b, c, d, e)
+ |USING 'python $scriptFilePath' AS (a, b, c, d, e)
+ |FROM v
+ """.stripMargin)
+
+ // In Hive1.2, it does not do well on Decimal conversion. For example, in this case,
+ // it converts a decimal value's type from Decimal(38, 18) to Decimal(1, 0). So we need
Review comment:
If we don't add `cast("decimal(1, 0)")`, what's the result of hive 1.2 and 2.3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586078522
**[Test build #118389 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118389/testReport)** for PR 27556 at commit [`a07ccff`](https://github.com/apache/spark/commit/a07ccff741ddde10ee4aa522534db62df08ce72e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585571835
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118334/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585571835
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118334/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990]
ScriptTransform should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990] ScriptTransform should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585536493
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23091/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#discussion_r378938183
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/ScriptTransformationSuite.scala
##########
@@ -186,6 +191,43 @@ class ScriptTransformationSuite extends SparkPlanTest with TestHiveSingleton wit
rowsDf.select("name").collect())
assert(uncaughtExceptionHandler.exception.isEmpty)
}
+
+ test("SPARK-25990: TRANSFORM should handle different data types correctly") {
+ assume(TestUtils.testCommandAvailable("python"))
+ val scriptFilePath = getTestResourcePath("test_script.py")
+
+ withTempView("v") {
+ val df = Seq(
+ (1, "1", 1.0, BigDecimal(1.0), new Timestamp(1)),
+ (2, "2", 2.0, BigDecimal(2.0), new Timestamp(2)),
+ (3, "3", 3.0, BigDecimal(3.0), new Timestamp(3))
+ ).toDF("a", "b", "c", "d", "e") // Note column d's data type is Decimal(38, 18)
+ df.createTempView("v")
+
+ val query = sql(
+ s"""
+ |SELECT
+ |TRANSFORM(a, b, c, d, e)
+ |USING 'python $scriptFilePath' AS (a, b, c, d, e)
+ |FROM v
+ """.stripMargin)
+
+ // In Hive1.2, it does not do well on Decimal conversion. For example, in this case,
+ // it converts a decimal value's type from Decimal(38, 18) to Decimal(1, 0). So we need
Review comment:
If we don't add `cast("decimal(1, 0)")`, what's the result of hive 1.2 and 2.3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586079154
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23146/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-586079152
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585820986
**[Test build #118370 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118370/testReport)** for PR 27556 at commit [`a07ccff`](https://github.com/apache/spark/commit/a07ccff741ddde10ee4aa522534db62df08ce72e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585891429
**[Test build #118370 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118370/testReport)** for PR 27556 at commit [`a07ccff`](https://github.com/apache/spark/commit/a07ccff741ddde10ee4aa522534db62df08ce72e).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585892301
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118370/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27556:
[SPARK-25990][SQL] ScriptTransformation should handle different data types
correctly
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585536232
**[Test build #118334 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118334/testReport)** for PR 27556 at commit [`5a176b3`](https://github.com/apache/spark/commit/5a176b3c907f56e2ba2c4fc104626e05ec4738b1).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27556: [SPARK-25990][SQL]
ScriptTransformation should handle different data types correctly
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27556: [SPARK-25990][SQL] ScriptTransformation should handle different data types correctly
URL: https://github.com/apache/spark/pull/27556#issuecomment-585571359
**[Test build #118334 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118334/testReport)** for PR 27556 at commit [`5a176b3`](https://github.com/apache/spark/commit/5a176b3c907f56e2ba2c4fc104626e05ec4738b1).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org