You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/03/09 10:28:17 UTC
[GitHub] [tvm] yuanfz98 opened a new pull request #10544: [TIR] Semantic extension for CSE Pass
yuanfz98 opened a new pull request #10544:
URL: https://github.com/apache/tvm/pull/10544
Hello,
This is a PR for #10211, aimed to add semantic extension for CSE Pass. Should be an easy PR.
For rewriting the test case using TVMScript, if no one is now working on it, I will later refactor the rest part.
Thanks for your time for your code review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yuanfz98 commented on a change in pull request #10544: [TIR] Semantic extension for CSE Pass
Posted by GitBox <gi...@apache.org>.
yuanfz98 commented on a change in pull request #10544:
URL: https://github.com/apache/tvm/pull/10544#discussion_r822739004
##########
File path: src/tir/transforms/common_subexpr_elim_tools.cc
##########
@@ -727,7 +728,10 @@ bool EquivalentTerms(const PrimExpr& a, const PrimExpr& b) {
// For now, we just check the syntactic equality, but that could later become a semantic test,
// for instance identifying computations modulo commutativity (like x+y and y+x), or modulo
// associativity (like (x+y)+z and x+(y+z)), etc.
- return EqualTerms(a, b);
+ arith::Analyzer analyser;
Review comment:
Yes I agree, I will close this PR. I will follow the ongoing development of pass dependencies and come back to this feature after. Thanks for your reply !
cc @FranckQC @zhiics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #10544: [TIR] Semantic extension for CSE Pass
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #10544:
URL: https://github.com/apache/tvm/pull/10544#discussion_r822686615
##########
File path: src/tir/transforms/common_subexpr_elim_tools.cc
##########
@@ -727,7 +728,10 @@ bool EquivalentTerms(const PrimExpr& a, const PrimExpr& b) {
// For now, we just check the syntactic equality, but that could later become a semantic test,
// for instance identifying computations modulo commutativity (like x+y and y+x), or modulo
// associativity (like (x+y)+z and x+(y+z)), etc.
- return EqualTerms(a, b);
+ arith::Analyzer analyser;
Review comment:
Thanks @yuanfz98 , One thing to note here is that running recursively simplification on every subexpression would result in a possibly quadratic complexity wrt to the expression size, so we would want to use it with care, perhaps only triger with limited expression length to avoid long compilation time.
In this particular case, directly running a simplification pass before the common subexpr elim would have a same effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] yuanfz98 closed pull request #10544: [TIR] Semantic extension for CSE Pass
Posted by GitBox <gi...@apache.org>.
yuanfz98 closed pull request #10544:
URL: https://github.com/apache/tvm/pull/10544
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org