[GitHub] [spark] cloud-fan commented on a change in pull request #35660: [SPARK-37932][SQL] Remove pruning the attributes mapping in QueryPlan

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #35660:
URL: https://github.com/apache/spark/pull/35660#discussion_r814845277



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
##########
@@ -327,16 +323,7 @@ abstract class QueryPlan[PlanType <: QueryPlan[PlanType]]
           val existingAttrMappingSet = transferAttrMapping.map(_._2).toSet
           newValidAttrMapping.filterNot { case (_, a) => existingAttrMappingSet.contains(a) }
         }
-        val resultAttrMapping = if (canGetOutput(plan)) {

Review comment:
       It's risky to remove this logic completely, as it helps to avoid the attribute map growing too big. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org