You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/08/07 02:40:28 UTC
Review Request 68251: Pass compiler/linker flags when building the
gRPC bundle in libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68251/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and James Peach.
Bugs: MESOS-9137
https://issues.apache.org/jira/browse/MESOS-9137
Repository: mesos
Description
-------
Since gRPC does not use Autotools, we have to manually pass compiler and
linker flags when issuing `make` to make the build flags consistent with
the Mesos build that initiate the gRPC bundle build.
With this fix, libprocess can be configured as follows to enable the
thread sanitizer:
CFLAGS='-fsanitize=thread'
CXXFLAGS='-fsanitize=thread'
LDFLAGS='-fsanitize=thread'
Also, we now only compile `libglog.la`, as we do in Mesos builds, to
avoid the following GLOG compilation issue when enabling the thread
sanitizer: https://github.com/google/glog/issues/54
Diffs
-----
3rdparty/libprocess/3rdparty/Makefile.am 55414190fd8fb8f9f2d220701ed7531b99b95797
Diff: https://reviews.apache.org/r/68251/diff/1/
Testing
-------
`make check` for standalone libprocess build.
Thanks,
Chun-Hung Hsiao
Re: Review Request 68251: Pass compiler/linker flags when building
the gRPC bundle in libprocess.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68251/#review206933
-----------------------------------------------------------
PASS: Mesos patch 68251 was successfully built and tested.
Reviews applied: `['68250', '68251']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2110/mesos-review-68251
- Mesos Reviewbot Windows
On Aug. 7, 2018, 2:40 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68251/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Bugs: MESOS-9137
> https://issues.apache.org/jira/browse/MESOS-9137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC does not use Autotools, we have to manually pass compiler and
> linker flags when issuing `make` to make the build flags consistent with
> the Mesos build that initiate the gRPC bundle build.
>
> With this fix, libprocess can be configured as follows to enable the
> thread sanitizer:
> CFLAGS='-fsanitize=thread'
> CXXFLAGS='-fsanitize=thread'
> LDFLAGS='-fsanitize=thread'
>
> Also, we now only compile `libglog.la`, as we do in Mesos builds, to
> avoid the following GLOG compilation issue when enabling the thread
> sanitizer: https://github.com/google/glog/issues/54
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 55414190fd8fb8f9f2d220701ed7531b99b95797
>
>
> Diff: https://reviews.apache.org/r/68251/diff/1/
>
>
> Testing
> -------
>
> `make check` for standalone libprocess build.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 68251: Pass compiler/linker flags when building
the gRPC bundle in libprocess.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68251/#review206945
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/Makefile.am
Line 130 (original), 132 (patched)
<https://reviews.apache.org/r/68251/#comment290124>
Unfortunately, you run into the same problem if you configure with `--enable-install-module-dependencies` since that does `make install` on the bundled glog. I'm not sure it is worth trying to fix that case.
- James Peach
On Aug. 7, 2018, 2:40 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68251/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 2:40 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and James Peach.
>
>
> Bugs: MESOS-9137
> https://issues.apache.org/jira/browse/MESOS-9137
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Since gRPC does not use Autotools, we have to manually pass compiler and
> linker flags when issuing `make` to make the build flags consistent with
> the Mesos build that initiate the gRPC bundle build.
>
> With this fix, libprocess can be configured as follows to enable the
> thread sanitizer:
> CFLAGS='-fsanitize=thread'
> CXXFLAGS='-fsanitize=thread'
> LDFLAGS='-fsanitize=thread'
>
> Also, we now only compile `libglog.la`, as we do in Mesos builds, to
> avoid the following GLOG compilation issue when enabling the thread
> sanitizer: https://github.com/google/glog/issues/54
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/Makefile.am 55414190fd8fb8f9f2d220701ed7531b99b95797
>
>
> Diff: https://reviews.apache.org/r/68251/diff/1/
>
>
> Testing
> -------
>
> `make check` for standalone libprocess build.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>