You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Brandon Williams (Created) (JIRA)" <ji...@apache.org> on 2011/11/13 17:33:51 UTC

[jira] [Created] (CASSANDRA-3489) EncryptionOptions should be instantiated

EncryptionOptions should be instantiated
----------------------------------------

                 Key: CASSANDRA-3489
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3489
             Project: Cassandra
          Issue Type: Bug
          Components: Core
    Affects Versions: 1.0.1
            Reporter: Brandon Williams
            Assignee: Brandon Williams
            Priority: Minor
             Fix For: 1.0.4


As the title says, otherwise you get an NPE when the options are missing from the yaml.  It's included in my second patch on CASSANDRA-3045 and is a one line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CASSANDRA-3489) EncryptionOptions should be instantiated

Posted by "Brandon Williams (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brandon Williams updated CASSANDRA-3489:
----------------------------------------

    Attachment: 3489.txt

I could only find the special case added the first time we fixed this back in 0.8 for CASSANDRA-3007.  Attached patch removes that and instantiates the default instead.
                
> EncryptionOptions should be instantiated
> ----------------------------------------
>
>                 Key: CASSANDRA-3489
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3489
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 1.0.5
>
>         Attachments: 3489.txt
>
>
> As the title says, otherwise you get an NPE when the options are missing from the yaml.  It's included in my second patch on CASSANDRA-3045 and is a one line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3489) EncryptionOptions should be instantiated

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161126#comment-13161126 ] 

Jonathan Ellis commented on CASSANDRA-3489:
-------------------------------------------

(Checked, and 0.8 OTC does have the null check.  So we're good there.)
                
> EncryptionOptions should be instantiated
> ----------------------------------------
>
>                 Key: CASSANDRA-3489
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3489
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 1.0.6
>
>         Attachments: 3489.txt
>
>
> As the title says, otherwise you get an NPE when the options are missing from the yaml.  It's included in my second patch on CASSANDRA-3045 and is a one line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3489) EncryptionOptions should be instantiated

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161125#comment-13161125 ] 

Jonathan Ellis commented on CASSANDRA-3489:
-------------------------------------------

Hmm.  I thought the other place was OTC, but that's going to NPE in the current code base.  So +1 for this patch.
                
> EncryptionOptions should be instantiated
> ----------------------------------------
>
>                 Key: CASSANDRA-3489
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3489
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 1.0.6
>
>         Attachments: 3489.txt
>
>
> As the title says, otherwise you get an NPE when the options are missing from the yaml.  It's included in my second patch on CASSANDRA-3045 and is a one line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CASSANDRA-3489) EncryptionOptions should be instantiated

Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-3489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149311#comment-13149311 ] 

Jonathan Ellis commented on CASSANDRA-3489:
-------------------------------------------

There's a bunch of "if encryption options is null then ignore it" special cases already, if you're going to instantiate a default instead then let's get rid of those.

May also need to be applied to 0.8 unless aforesaid special cases cover everything.
                
> EncryptionOptions should be instantiated
> ----------------------------------------
>
>                 Key: CASSANDRA-3489
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3489
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.0.1
>            Reporter: Brandon Williams
>            Assignee: Brandon Williams
>            Priority: Minor
>             Fix For: 1.0.4
>
>
> As the title says, otherwise you get an NPE when the options are missing from the yaml.  It's included in my second patch on CASSANDRA-3045 and is a one line fix.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira