You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/06/06 00:02:56 UTC
[GitHub] [phoenix] gjacoby126 opened a new pull request #798: PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow
gjacoby126 opened a new pull request #798:
URL: https://github.com/apache/phoenix/pull/798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #798: PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #798:
URL: https://github.com/apache/phoenix/pull/798#issuecomment-640895669
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 merged pull request #798: PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow
Posted by GitBox <gi...@apache.org>.
gjacoby126 merged pull request #798:
URL: https://github.com/apache/phoenix/pull/798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #798: PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #798:
URL: https://github.com/apache/phoenix/pull/798#issuecomment-639907636
First pass -- this gets the running time down from ~30min to ~16.5min by giving each table a unique name rather than creating/dropping all tables for each test. Will take a second look to see if I can get it down lower. Perhaps we could change parameter order so that the same minicluster can be reused more, or just use fewer tables for some of the corner case / error handling tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] gjacoby126 commented on pull request #798: PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow
Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on pull request #798:
URL: https://github.com/apache/phoenix/pull/798#issuecomment-641544349
Thanks for the review, @swaroopak and @gokceni
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix] swaroopak commented on a change in pull request #798: PHOENIX-5942 - ParameterizedIndexUpgradeToolIT is too slow
Posted by GitBox <gi...@apache.org>.
swaroopak commented on a change in pull request #798:
URL: https://github.com/apache/phoenix/pull/798#discussion_r436970316
##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/ParameterizedIndexUpgradeToolIT.java
##########
@@ -169,59 +167,144 @@ private void setClusterProperties() {
private void prepareSetup() throws SQLException {
//inputList is "TEST.MOCK1,TEST1.MOCK2,TEST.MOCK3";
+
+ String mockTableOne = "TEST." + generateUniqueName();
+ TABLE_LIST[0] = mockTableOne;
+ String mockTableTwo = "TEST1." + generateUniqueName();
+ TABLE_LIST[1] = mockTableTwo;
+ String mockTableThree = "TEST." + generateUniqueName();
+ TABLE_LIST[2] = mockTableThree;
+ String multiTenantTable = "TEST." + generateUniqueName();
+ TABLE_LIST[3] = multiTenantTable;
+ INPUT_LIST = StringUtils.join(TABLE_LIST, ",");
if (isNamespaceEnabled) {
- conn.createStatement().execute("CREATE SCHEMA TEST");
- conn.createStatement().execute("CREATE SCHEMA TEST1");
+ TABLE_LIST_NAMESPACE[0] = mockTableOne.replace(".", ":");
+ TABLE_LIST_NAMESPACE[1] = mockTableTwo.replace(".", ":");
+ TABLE_LIST_NAMESPACE[2] = mockTableThree.replace(".", ":");
+ TABLE_LIST_NAMESPACE[3] = multiTenantTable.replace(".", ":");
+ conn.createStatement().execute("CREATE SCHEMA IF NOT EXISTS TEST");
+ conn.createStatement().execute("CREATE SCHEMA IF NOT EXISTS TEST1");
}
- conn.createStatement().execute("CREATE TABLE TEST.MOCK1 (id bigint NOT NULL "
+
+
+
Review comment:
nit: extra lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org