You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/03/16 15:33:19 UTC

DO NOT REPLY [Bug 48922] New: org.apache.catalina.connector.Request clone static SimpleDateFormat

https://issues.apache.org/bugzilla/show_bug.cgi?id=48922

           Summary: org.apache.catalina.connector.Request clone static
                    SimpleDateFormat
           Product: Tomcat 6
           Version: unspecified
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: xmedeko@gmail.com


Faster usage of the thread unsafe SimpleDateFormat is:

private static final SimpleDateFormat FORMAT_PROTOTYPE = new
SimpleDateFormat("...", Locale.ROOT);
static {
  format.setTimeZone(GMT_ZONE);
}

protected SimpleDateFormat format = (SimpleDateFormat)FORMAT_PROTOTYPE.clone();

Please, apply this pattern to the formats[] field. It shoudl speed up the
request processing a little bit.

Thanks

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48922] org.apache.catalina.connector.Request clone static SimpleDateFormat

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48922

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |enhancement

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48922] org.apache.catalina.connector.Request clone static SimpleDateFormat

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48922

--- Comment #2 from Daniel Lemon <da...@gmail.com> 2010-04-17 11:41:50 EDT ---
Created an attachment (id=25318)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25318)
Requested changes added to the Request Class

On my machine I saw an increase in roughly 12% of performance.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 48922] org.apache.catalina.connector.Request clone static SimpleDateFormat

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=48922

--- Comment #1 from Daniel Lemon <da...@gmail.com> 2010-04-17 11:40:00 EDT ---
Created an attachment (id=25317)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25317)
Test performance creation of the Request() object

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org