You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by wikier <gi...@git.apache.org> on 2015/10/19 16:45:07 UTC
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
GitHub user wikier opened a pull request:
https://github.com/apache/commons-lang/pull/112
LANG-1175: removed ant-based build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wikier/commons-lang master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-lang/pull/112.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #112
----
commit c3e250abb364187bd2193318d972a0df89c5861c
Author: Sergio Fernández <wi...@apache.org>
Date: 2015-10-19T14:44:42Z
LANG-1175: removed ant-based build
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by wikier <gi...@git.apache.org>.
Github user wikier commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42416127
--- Diff: .gitignore ---
@@ -4,6 +4,7 @@ target
maven-eclipse.xml
build.properties
site-content
+*~
--- End diff --
commonly some editors (e.g., emacs) use the suffix `~` to create backup files
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/112#issuecomment-149324877
Looks good to me now. Feel free to merge to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by britter <gi...@git.apache.org>.
Github user britter commented on the pull request:
https://github.com/apache/commons-lang/pull/112#issuecomment-149307896
Looks good to me. But we should also drop:
* default.properties
* src/release-tools (it also depends on the main ant build)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42408346
--- Diff: .gitignore ---
@@ -4,6 +4,7 @@ target
maven-eclipse.xml
build.properties
site-content
+*~
--- End diff --
What does this mean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by wikier <gi...@git.apache.org>.
Github user wikier commented on the pull request:
https://github.com/apache/commons-lang/pull/112#issuecomment-149428870
I don't have permissions on the main git repo, so please @britter merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by wikier <gi...@git.apache.org>.
Github user wikier commented on the pull request:
https://github.com/apache/commons-lang/pull/112#issuecomment-149323511
updated from some comments by @britter
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42416452
--- Diff: src/assembly/src.xml ---
@@ -32,7 +32,6 @@
<include>pom.xml</include>
<include>PROPOSAL.html</include>
<include>RELEASE-NOTES.txt</include>
- <include>build.xml</include>
<include>default.properties</include>
--- End diff --
Should also be dropped
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/commons-lang/pull/112
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42408375
--- Diff: .gitignore ---
@@ -4,6 +4,7 @@ target
maven-eclipse.xml
build.properties
--- End diff --
Can be dropped from .gitignore
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] commons-lang pull request: LANG-1175: removed ant-based build
Posted by britter <gi...@git.apache.org>.
Github user britter commented on a diff in the pull request:
https://github.com/apache/commons-lang/pull/112#discussion_r42408499
--- Diff: src/changes/changes.xml ---
@@ -22,6 +22,7 @@
<body>
<release version="3.5" date="tba" description="tba">
+ <action issue="LANG-1175" type="fix" dev="wikier" dute-to="Benedikt Ritter">Remove Ant-based build</action>
--- End diff --
Copy and paste error. Should be `due-to`. I've corrected this for the other lines.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---