You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/03/27 19:09:54 UTC
Review Request 19738: Fixed tabs in stout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19738/
-----------------------------------------------------------
Review request for mesos, Adam Berry and Dominic Hamon.
Repository: mesos-git
Description
-------
Caught some tabs with the latest fix to mesos-style.py
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp b76b0b089be00fa0a6f884b3c97a847d8c86a0cb
3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp d6b070fa4ab3958c1e9302f6a2fc0ca63fc0239a
Diff: https://reviews.apache.org/r/19738/diff/
Testing
-------
make
? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
Checking 403 files...
Total errors found: 0
Thanks,
Vinod Kone
Re: Review Request 19738: Fixed tabs in stout.
Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19738/#review38905
-----------------------------------------------------------
Ship it!
Ship It!
- Niklas Nielsen
On March 27, 2014, 11:09 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19738/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 11:09 a.m.)
>
>
> Review request for mesos, Adam Berry and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Caught some tabs with the latest fix to mesos-style.py
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp b76b0b089be00fa0a6f884b3c97a847d8c86a0cb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp d6b070fa4ab3958c1e9302f6a2fc0ca63fc0239a
>
> Diff: https://reviews.apache.org/r/19738/diff/
>
>
> Testing
> -------
>
> make
>
> ? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
> Checking 403 files...
> Total errors found: 0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 19738: Fixed tabs in stout.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19738/#review38907
-----------------------------------------------------------
Bad patch!
Reviews applied: [19738]
Failed command: git apply --index 19738.patch
Error:
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp:33
error: 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp: patch does not apply
error: patch failed: 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp:307
error: 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp: patch does not apply
- Mesos ReviewBot
On March 27, 2014, 6:09 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19738/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 6:09 p.m.)
>
>
> Review request for mesos, Adam Berry and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Caught some tabs with the latest fix to mesos-style.py
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp b76b0b089be00fa0a6f884b3c97a847d8c86a0cb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp d6b070fa4ab3958c1e9302f6a2fc0ca63fc0239a
>
> Diff: https://reviews.apache.org/r/19738/diff/
>
>
> Testing
> -------
>
> make
>
> ? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
> Checking 403 files...
> Total errors found: 0
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 19738: Fixed tabs in stout.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19738/#review38773
-----------------------------------------------------------
Ship it!
Ship It!
- Dominic Hamon
On March 27, 2014, 11:09 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19738/
> -----------------------------------------------------------
>
> (Updated March 27, 2014, 11:09 a.m.)
>
>
> Review request for mesos, Adam Berry and Dominic Hamon.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Caught some tabs with the latest fix to mesos-style.py
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/foreach.hpp b76b0b089be00fa0a6f884b3c97a847d8c86a0cb
> 3rdparty/libprocess/3rdparty/stout/include/stout/format.hpp d6b070fa4ab3958c1e9302f6a2fc0ca63fc0239a
>
> Diff: https://reviews.apache.org/r/19738/diff/
>
>
> Testing
> -------
>
> make
>
> ? mesos git:(vinod/tab_fix) ? ./support/mesos-style.py
> Checking 403 files...
> Total errors found: 0
>
>
> Thanks,
>
> Vinod Kone
>
>