You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/25 13:37:58 UTC
[GitHub] [flink] KurtYoung opened a new pull request #11910: [FLINK-17339][table] Change default planner to blink
KurtYoung opened a new pull request #11910:
URL: https://github.com/apache/flink/pull/11910
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Travis CI to do that following [this guide](https://flink.apache.org/contributing/contribute-code.html#open-a-pull-request).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Change the default planner to blink, and update test cases caused by this.
## Verifying this change
This change is already covered by existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619465234
@libenchao Thanks for the reviewing, I've addressed your comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162025293",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=241",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b UNKNOWN
* 9b4a8cd3d1f463367006e01be1074991f1c29527 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162025293) Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619502534
@libenchao I've noticed them. I think it's ok to use blink planner explicitly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619381213
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 1bb8ea40773d869f336a61f7304105301f5bb7ab (Sat Apr 25 13:40:03 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415272447
##########
File path: flink-python/pyflink/table/tests/test_table_environment_api.py
##########
@@ -275,16 +275,16 @@ def test_create_table_environment_with_blink_planner(self):
self.assertEqual(
planner.getClass().getName(),
- "org.apache.flink.table.planner.StreamPlanner")
+ "org.apache.flink.table.planner.delegation.StreamPlanner")
t_env = StreamTableEnvironment.create(
- environment_settings=EnvironmentSettings.new_instance().use_blink_planner().build())
+ environment_settings=EnvironmentSettings.new_instance().use_old_planner().build())
Review comment:
The test is trying to cover all 3 situations, 1) default behavior 2) use blink planner explicitly 3) use old planner explicitly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415271861
##########
File path: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamSQLExample.scala
##########
@@ -49,12 +49,16 @@ object StreamSQLExample {
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = if (planner == "blink") { // use blink planner in streaming mode
Review comment:
I think current is also fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162025293",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=241",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb8ea40773d869f336a61f7304105301f5bb7ab Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161974663) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233)
* 2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b UNKNOWN
* 9b4a8cd3d1f463367006e01be1074991f1c29527 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/162025293) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb8ea40773d869f336a61f7304105301f5bb7ab Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161974663) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233)
* 2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb8ea40773d869f336a61f7304105301f5bb7ab UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619509103
Yes, it's FLINK-17340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on a change in pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
libenchao commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415068116
##########
File path: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamSQLExample.scala
##########
@@ -49,12 +49,16 @@ object StreamSQLExample {
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = if (planner == "blink") { // use blink planner in streaming mode
val settings = EnvironmentSettings.newInstance()
- .useBlinkPlanner()
- .inStreamingMode()
- .build()
+ .useBlinkPlanner()
Review comment:
change the default planner to blink for line 46?
##########
File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/EnvironmentSettings.java
##########
@@ -159,8 +159,8 @@ public boolean isStreamingMode() {
private static final String BLINK_PLANNER_FACTORY = "org.apache.flink.table.planner.delegation.BlinkPlannerFactory";
private static final String BLINK_EXECUTOR_FACTORY = "org.apache.flink.table.planner.delegation.BlinkExecutorFactory";
- private String plannerClass = OLD_PLANNER_FACTORY;
Review comment:
also update java doc for `EnvironmentSettings`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb8ea40773d869f336a61f7304105301f5bb7ab Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161974663) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233)
* 2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] KurtYoung commented on a change in pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
KurtYoung commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415272090
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -172,7 +172,7 @@ under the License.
<!-- A planner dependency won't be necessary once FLIP-32 has been completed. -->
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
Review comment:
I'm not sure about this, did you see any problem with it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415287241
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -172,7 +172,7 @@ under the License.
<!-- A planner dependency won't be necessary once FLIP-32 has been completed. -->
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
Review comment:
It is not a big deal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb8ea40773d869f336a61f7304105301f5bb7ab Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/161974663) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/162025293",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=241",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b UNKNOWN
* 9b4a8cd3d1f463367006e01be1074991f1c29527 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/162025293) Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=241)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619484573
@KurtYoung Thanks for addressing my comments. It seems that you didn't notice
> `TpcdsTestProgram` and `BatchSQLTestProgram` is missing
in the comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619382665
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"status" : "CANCELED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/161974663",
"triggerID" : "1bb8ea40773d869f336a61f7304105301f5bb7ab",
"triggerType" : "PUSH"
}, {
"hash" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b",
"triggerType" : "PUSH"
}, {
"hash" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "9b4a8cd3d1f463367006e01be1074991f1c29527",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 1bb8ea40773d869f336a61f7304105301f5bb7ab Travis: [CANCELED](https://travis-ci.com/github/flink-ci/flink/builds/161974663) Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=233)
* 2d5fb0ba1cd6ccc17ef1643bcb9ad6236b7ac79b UNKNOWN
* 9b4a8cd3d1f463367006e01be1074991f1c29527 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] libenchao commented on pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
libenchao commented on pull request #11910:
URL: https://github.com/apache/flink/pull/11910#issuecomment-619505337
@KurtYoung Thanks for the explain, the changes LGTM now.
BTW, we should also update the documentation about this change. (I think you must be aware of this, and planned to do it in another issue. Just a reminder)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #11910: [FLINK-17339][table] Change default planner to blink
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #11910:
URL: https://github.com/apache/flink/pull/11910#discussion_r415261016
##########
File path: flink-connectors/flink-connector-cassandra/pom.xml
##########
@@ -172,7 +172,7 @@ under the License.
<!-- A planner dependency won't be necessary once FLIP-32 has been completed. -->
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-table-planner_${scala.binary.version}</artifactId>
+ <artifactId>flink-table-planner-blink_${scala.binary.version}</artifactId>
Review comment:
Why just change cassandra?
Maybe scope to test and remove above comments?
##########
File path: flink-examples/flink-examples-table/src/main/scala/org/apache/flink/table/examples/scala/StreamSQLExample.scala
##########
@@ -49,12 +49,16 @@ object StreamSQLExample {
val env = StreamExecutionEnvironment.getExecutionEnvironment
val tEnv = if (planner == "blink") { // use blink planner in streaming mode
Review comment:
Minor: `EnvironmentSettings.Builder settingsBuilder = EnvironmentSettings.newInstance().inStreamingMode();` to reuse `StreamTableEnvironment.create` code.
`StreamSQLExample.java` too.
##########
File path: flink-python/pyflink/table/tests/test_table_environment_api.py
##########
@@ -275,16 +275,16 @@ def test_create_table_environment_with_blink_planner(self):
self.assertEqual(
planner.getClass().getName(),
- "org.apache.flink.table.planner.StreamPlanner")
+ "org.apache.flink.table.planner.delegation.StreamPlanner")
t_env = StreamTableEnvironment.create(
- environment_settings=EnvironmentSettings.new_instance().use_blink_planner().build())
+ environment_settings=EnvironmentSettings.new_instance().use_old_planner().build())
Review comment:
Why change to old? test name is `test_create_table_environment_with_blink_planner`? maybe should change method name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org