[jira] [Commented] (HBASE-24788) Fix the connection leaks on getting hbase admin from unclosed connection

["Viraj Jasani (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17173601#comment-17173601 ] 

Viraj Jasani commented on HBASE-24788:
--------------------------------------

Oh yes, this was an oversight, apologies. Let me fix this for all affected branches. Even if master branch has to break this compatibility, it can be done later in separate Jira but it doesn't belong to the scope of this Jira IMHO.

> Fix the connection leaks on getting hbase admin from unclosed connection
> ------------------------------------------------------------------------
>
>                 Key: HBASE-24788
>                 URL: https://issues.apache.org/jira/browse/HBASE-24788
>             Project: HBase
>          Issue Type: Bug
>          Components: mapreduce
>    Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.6.0
>            Reporter: Sandeep Pal
>            Assignee: Sandeep Pal
>            Priority: Major
>             Fix For: 3.0.0-alpha-1, 2.3.1, 1.7.0, 2.4.0, 2.2.7
>
>
> Observed the significant increase in ZK connection on performance testing on map reduce jobs. Turns out the [TableOutputFormat.checkOutputSpecs()|https://github.com/apache/hbase/blob/master/hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/TableOutputFormat.java#L182]  is not closing the connection it uses to get the hbase admin. It closes the hbase admin but never close the connection to get the admin.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)