You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/04 14:45:12 UTC

[GitHub] [airflow] feluelle commented on a change in pull request #10158: Documentation artifact are also uploaded as GitHub Actions Artifacts

feluelle commented on a change in pull request #10158:
URL: https://github.com/apache/airflow/pull/10158#discussion_r465103961



##########
File path: scripts/ci/libraries/_initialization.sh
##########
@@ -148,6 +151,23 @@ function initialize_common_environment {
         )
     fi
 
+    # Common variables passed via docker commands
+    EXTRA_DOCKER_FLAGS+=(
+        "--env" "INSTALL_AIRFLOW_VERSION"
+        "--env" "PYTHONDONTWRITEBYTECODE"
+        "--env" "VERBOSE"
+        "--env" "VERBOSE_COMMANDS"
+        "--env" "HOST_USER_ID"
+        "--env" "HOST_GROUP_ID"
+        "--env" "HOST_OS"
+        "--env" "HOST_HOME"
+        "--env" "HOST_AIRFLOW_SOURCES"
+        "--env" "PYTHON_MAJOR_MINOR_VERSION"
+        "--env" "VERSION_SUFFIX_FOR_PYPI"
+        "--env" "VERSION_SUFFIX_FOR_SVN"
+        "--env" "CI"

Review comment:
       How about using [--env-file](https://docs.docker.com/engine/reference/commandline/run/#set-environment-variables--e---env---env-file) ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org