You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by bijanfahimi <gi...@git.apache.org> on 2017/08/30 08:22:33 UTC

[GitHub] storm pull request #2298: STORM-2694: STORM-Add KafkaTupleListener to storm-...

GitHub user bijanfahimi opened a pull request:

    https://github.com/apache/storm/pull/2298

    STORM-2694: STORM-Add KafkaTupleListener to storm-kafka-client

    PR for the 1.x branch.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bijanfahimi/storm STORM-KafkaRetry-1.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2298.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2298
    
----
commit 43625c2637b65f4452cb21f9983274daf6d7f357
Author: Bijan Fahimi <bi...@iqser.com>
Date:   2017-08-30T08:16:31Z

    Add KafkaTupleListener to storm-kafka-client

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2298: STORM-2694: STORM-Add KafkaTupleListener to storm-kafka-c...

Posted by srdo <gi...@git.apache.org>.
Github user srdo commented on the issue:

    https://github.com/apache/storm/pull/2298
  
    @bijanfahimi Thanks. I'll merge this shortly. Some of the tests in 1.x are unfortunately a little flaky. The test failures are unrelated to your change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request #2298: STORM-2694: STORM-Add KafkaTupleListener to storm-...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2298


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm issue #2298: STORM-2694: STORM-Add KafkaTupleListener to storm-kafka-c...

Posted by bijanfahimi <gi...@git.apache.org>.
Github user bijanfahimi commented on the issue:

    https://github.com/apache/storm/pull/2298
  
    @srdo I have created a PR on the 1.x branch. There are test failures in the PR, however, I am not sure if the errors are related since I haven't changed any logic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---