You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@directory.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2015/10/26 00:27:27 UTC

[jira] [Commented] (DIRAPI-261) OID don't encode corrctly joint-iso-itu-t arcs

    [ https://issues.apache.org/jira/browse/DIRAPI-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14973492#comment-14973492 ] 

Emmanuel Lecharny commented on DIRAPI-261:
------------------------------------------

Partial fix : http://svn.apache.org/viewvc?rev=1710496&view=rev

This should handle the {{joint-iso-itu-t}} arc correctly (and the other too). It's mainly a fix for the {{fromString()}} method, which has been completely rewritten. Side result : it's also 2 times faster than the previous method (up to 3.5 millions OIDs parsed per second, compared to 1,77 million per second).

The code is way more complex, based on a FSA (which is described on [http://directory.staging.apache.org/api/user-guide/6.27-oid.html])

What remains to be done : the {{fromBytes(byte[])}} method does not handle correctly values longer than {{Long.MAX_VALUE}}, for the same reason.

> OID don't encode corrctly joint-iso-itu-t arcs
> ----------------------------------------------
>
>                 Key: DIRAPI-261
>                 URL: https://issues.apache.org/jira/browse/DIRAPI-261
>             Project: Directory Client API
>          Issue Type: Bug
>    Affects Versions: 1.0.0-M32
>            Reporter: Emmanuel Lecharny
>            Priority: Critical
>             Fix For: 1.0.0-M33
>
>
> The {{joint-iso-itu-t(2)}} arc is not encoded correctly : the second node is assumed to be below 40, which is not correct.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)