You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Andrew Lamb (Jira)" <ji...@apache.org> on 2021/03/16 20:51:00 UTC
[jira] [Closed] (ARROW-11979) [Rust] Combine limit into SortOptions
[ https://issues.apache.org/jira/browse/ARROW-11979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Lamb closed ARROW-11979.
-------------------------------
Resolution: Won't Do
turns out this is tricker due to SortOptions being used for single column sorting as well as multi-column sorts
> [Rust] Combine limit into SortOptions
> -------------------------------------
>
> Key: ARROW-11979
> URL: https://issues.apache.org/jira/browse/ARROW-11979
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Andrew Lamb
> Assignee: Andrew Lamb
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The `sort_limit` kernel was added by @sundy-li in https://github.com/apache/arrow/pull/9602
> While writing some doc examples in https://github.com/apache/arrow/pull/9721, it occured to me we could potentially simplify the API so I figured I would offer a proposed PR for comment
> # Rationale
> Since we already have a `SortOptions` structure that controls sorting options, we could also add the `limit` to that structure rather than adding a new `sort_limit` function and still avoid changing the API
> # Changes
> Move the `limit` option to `SortOptions`
--
This message was sent by Atlassian Jira
(v8.3.4#803005)