You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/23 14:00:48 UTC
[GitHub] [pulsar] lhotari opened a new pull request #8361: Use grpc-bom and protoc-gen-grpc-java version match grpc.version
lhotari opened a new pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361
- CI fails currently because of grpc version incompatibilities
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361#issuecomment-715474066
There seems to be some remaining issues, I cherry picked this to another PR and it still fails. Perhaps it's better to revert the grpc upgrade until the issue is completely resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari closed pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361#issuecomment-715494020
I opened #8363 to revert the grpc upgrade since master branch is currently broken. I'll close this PR because of that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361#issuecomment-715486688
I'm running an experiment in #8358 to see if reverting 647d3c22ee219e091fc29d809e8da982a25b6541 fixes the issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361#issuecomment-715369115
I found this issue https://github.com/grpc/grpc-java/issues/5556 and I would assume that upgrading protoc-gen-grpc-java.version fixes the problem. I just wonder why the checks passed in #8351 and this issue didn't show up earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361#issuecomment-715379651
There's a bug in the Github flow. It considers a pom.xml change a documentation only change. I filed #8362.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #8361: Use grpc-bom and make protoc-gen-grpc-java.version match grpc.version to fix grpc version incompatibility
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #8361:
URL: https://github.com/apache/pulsar/pull/8361#issuecomment-715366165
@pkumar-singh and @merlimat , please review these changes since they are related to the recent change #8351 . Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org