You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (Created) (JIRA)" <ji...@apache.org> on 2011/11/27 20:45:39 UTC

[jira] [Created] (LUCENE-3601) testIWondiskfull unreferenced files failure

testIWondiskfull unreferenced files failure
-------------------------------------------

                 Key: LUCENE-3601
                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
             Project: Lucene - Java
          Issue Type: Bug
            Reporter: Robert Muir


NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"

Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158722#comment-13158722 ] 

Robert Muir commented on LUCENE-3601:
-------------------------------------

+1 to commit the latest patch, and finally we end up with the original assert from the original test fail... whew

Thanks!
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Resolved] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Resolved) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir resolved LUCENE-3601.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 4.0

i'll mark this resolved, everything is ok but we still have the funkiness of MultiReader(SR, ...) and LUCENE-3605.
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 4.0
>
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157992#comment-13157992 ] 

Michael McCandless commented on LUCENE-3601:
--------------------------------------------

This test also fails, with a real (latent) bug!

{noformat}
ant test-core -Dtestcase=TestDeletionPolicy -Dtestmethod=testKeepNoneOnInitDeletionPolicy -Dtests.seed=-17f17ea52e636aba:125dd8f860320fcc:4884454c77ab99f3 -Dargs="-Dfile.encoding=UTF-8"
{noformat}

I think the problem here is we are failing to IFD.incRef the global _N.fnx file implicitly referenced by the in-memory SegmentInfos, and so IFD deletes it when it should not, leading to corruption.

To fix this one we need incRef (and matching decRef) somewhere...
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3601:
--------------------------------

    Attachment: LUCENE-3601.patch

patch for the issue, but i was thinking we should try to detect unreferenced files in all tests (because hitting this fail means you randomly ran out of disk when init'ing the writer writes its version header vints, which is rare).

The first problem (see my patch) is that IR.indexExists is returning true for some directories where if you actually then go and open an IW on them, you will get FNFE:

{noformat}
    [junit] Testcase: testAddOldIndexes(org.apache.lucene.index.TestBackwardsCompatibility):	Caused an ERROR
    [junit] _1.cfe
    [junit] java.io.FileNotFoundException: _1.cfe
    [junit] 	at org.apache.lucene.store.MockDirectoryWrapper.openInput(MockDirectoryWrapper.java:445)
    [junit] 	at org.apache.lucene.store.CompoundFileDirectory.readEntries(CompoundFileDirectory.java:101)
    [junit] 	at org.apache.lucene.store.CompoundFileDirectory.<init>(CompoundFileDirectory.java:67)
    [junit] 	at org.apache.lucene.index.SegmentInfo.loadFieldInfos(SegmentInfo.java:198)
    [junit] 	at org.apache.lucene.index.SegmentInfo.getFieldInfos(SegmentInfo.java:280)
    [junit] 	at org.apache.lucene.index.SegmentInfo.files(SegmentInfo.java:532)
    [junit] 	at org.apache.lucene.index.SegmentInfos.files(SegmentInfos.java:886)
    [junit] 	at org.apache.lucene.index.IndexFileDeleter.incRef(IndexFileDeleter.java:489)
    [junit] 	at org.apache.lucene.index.IndexFileDeleter.checkpoint(IndexFileDeleter.java:462)
    [junit] 	at org.apache.lucene.index.IndexFileDeleter.<init>(IndexFileDeleter.java:278)
    [junit] 	at org.apache.lucene.index.IndexWriter.<init>(IndexWriter.java:891)
    [junit] 	at org.apache.lucene.store.MockDirectoryWrapper.close(MockDirectoryWrapper.java:512)
    [junit] 	at org.apache.lucene.index.TestBackwardsCompatibility.testAddOldIndexes(TestBackwardsCompatibility.java:218)
{noformat}

                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158000#comment-13158000 ] 

Robert Muir commented on LUCENE-3601:
-------------------------------------

{quote}
IW.addIndexes(Dir[]) just copies files over, converting them to 4.0 style CFS (_X.cfe and _X.cfs files), if necessary. But the original SI for the added segment has "version" still set to 3.1, so when SI.files() is called it thinks this segment does not have an _X.cfe file and so that file gets (incorrectly, leading to corruption) removed.

Not quite sure how to fix this...
{quote}

This is one way (test then passes), but I'm not sure its the best fix. Personally I don't think we should be repackaging things into CFS on addindexes here, we should just do a straight copy always.

{noformat}
Index: src/java/org/apache/lucene/index/IndexWriter.java
===================================================================
--- src/java/org/apache/lucene/index/IndexWriter.java	(revision 1206734)
+++ src/java/org/apache/lucene/index/IndexWriter.java	(working copy)
@@ -2397,8 +2397,10 @@
           synchronized (this) { // Guard segmentInfos
             createCFS = !info.getUseCompoundFile()
                 && mergePolicy.useCompoundFile(segmentInfos, info)
-                // optimize case only for segments that don't share doc stores
-                && versionComparator.compare(info.getVersion(), "3.1") >= 0;
+                // optimize case only for segments that don't share doc stores,
+                // also since pre-4.0 segments use a different CFS format, don't 
+                // bogusly package them up in a 4.0 format.
+                && versionComparator.compare(info.getVersion(), "4.0") >= 0;
           }
           
           IOContext context = new IOContext(new MergeInfo(info.docCount, info.sizeInBytes(), true, -1));
{noformat}

                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Michael McCandless (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-3601:
---------------------------------------

    Attachment: LUCENE-3601.patch

Patch to fix the fnx tracking, so that in-RAM (uncommitted) SISs also claim the global fnx file they rely on.
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158413#comment-13158413 ] 

Robert Muir commented on LUCENE-3601:
-------------------------------------

The fsync issue is because only directoryreader properly syncs, and this test makes a multireader of segmentreaders.

for now i'll disable it for this test with a TODO.
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Muir updated LUCENE-3601:
--------------------------------

    Attachment: LUCENE-3601.patch

updated patch: fixing the CFS bug as discussed, but with a new fail:

Looking at the FNX bug, I thought that MDW should also really be testing that sync is being called correctly as well, so after checkindex + new IndexWriter I added crash() + checkindex + new indexwriter.

This only causes one additional fail, in TestMultiReader, maybe its a false fail, I didn't look any further... but we should be able to do this I think for all tests...
{noformat}
    [junit] ------------- Standard Output ---------------
    [junit] CheckIndex failed
    [junit] Segments file=segments_4 numSegments=2 version=4.0 format=FORMAT_4_0 [Lucene 4.0]
    [junit]   1 of 2: name=_0 docCount=1
    [junit]     codec=Lucene40
    [junit]     compound=false
    [junit]     hasProx=true
    [junit]     numFiles=48
    [junit]     size (MB)=0.617
    [junit]     diagnostics = {os.version=3.0.0-12-generic, os=Linux, lucene.version=4.0-SNAPSHOT, source=flush, os.arch=amd64, java.version=1.7.0_01, java.vendor=Oracle Corporation}
    [junit]     has deletions [delFileName=_0_1.del]
    [junit]     test: open reader.........FAILED
    [junit]     WARNING: fixIndex() would remove reference to this segment; full exception:
    [junit] org.apache.lucene.index.CorruptIndexException: document count mismatch: deleted docs count 0 vs segment doc count 1 segment=_0
    [junit] 	at org.apache.lucene.index.SegmentReader.loadLiveDocs(SegmentReader.java:166)
    [junit] 	at org.apache.lucene.index.SegmentReader.get(SegmentReader.java:116)
    [junit] 	at org.apache.lucene.index.SegmentReader.get(SegmentReader.java:91)
    [junit] 	at org.apache.lucene.index.CheckIndex.checkIndex(CheckIndex.java:528)
    [junit] 	at org.apache.lucene.util._TestUtil.checkIndex(_TestUtil.java:155)
{noformat}
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13157990#comment-13157990 ] 

Michael McCandless commented on LUCENE-3601:
--------------------------------------------

That exception is due to a real (latent) bug!

IW.addIndexes(Dir[]) just copies files over, converting them to 4.0 style CFS (_X.cfe and _X.cfs files), if necessary.  But the original SI for the added segment has "version" still set to 3.1, so when SI.files() is called it thinks this segment does not have an _X.cfe file and so that file gets (incorrectly, leading to corruption) removed.

Not quite sure how to fix this...
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Updated] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Michael McCandless (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Michael McCandless updated LUCENE-3601:
---------------------------------------

    Attachment: LUCENE-3601.patch

New patch, adds in assert to MDW.close that there are no unref'd files.  I think it's ready... I'll commit shortly.
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Robert Muir (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158510#comment-13158510 ] 

Robert Muir commented on LUCENE-3601:
-------------------------------------

I committed fixes for stuff except the FNX failure. I'll backport to 3.x.
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch, LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] [Commented] (LUCENE-3601) testIWondiskfull unreferenced files failure

Posted by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-3601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13158003#comment-13158003 ] 

Michael McCandless commented on LUCENE-3601:
--------------------------------------------

bq. Personally I don't think we should be repackaging things into CFS on addindexes here, we should just do a straight copy always.

+1

I think the repackaging is too risky?  What if we change CFS format in 4.1....
                
> testIWondiskfull unreferenced files failure
> -------------------------------------------
>
>                 Key: LUCENE-3601
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3601
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-3601.patch
>
>
> NOTE: reproduce with: ant test -Dtestcase=TestIndexWriterOnDiskFull -Dtestmethod=testAddDocumentOnDiskFull -Dtests.seed=aff9b14dd518cfb:4d2f112726e2947f:-2b03094a43a947ee -Dtests.multiplier=3 -Dargs="-Dfile.encoding=ISO8859-1"
> Reproduces some of the time...

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org