You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/20 08:03:25 UTC

[GitHub] [apisix-ingress-controller] Chever-John opened a new pull request, #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Chever-John opened a new pull request, #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031

   … Ingress
   
   <!-- Please answer these questions before submitting a pull request -->
   
   ### Type of change:
   
   <!-- Please delete options that are not relevant. -->
   
   - [ ] Bugfix
   - [ ] New feature provided
   - [ ] Improve performance
   - [ ] Backport patches
   
   ### What this PR does / why we need it:
   <!--- Why is this change required? What problem does it solve? -->
   <!--- If it fixes an open issue, please link to the issue here. -->
   
   ### Pre-submission checklist:
   
   <!--
   Please follow the requirements:
   1. Use Draft if the PR is not ready to be reviewed
   2. Test is required for the feat/fix PR, unless you have a good reason
   3. Doc is required for the feat PR
   4. Use a new commit to resolve review instead of `push -f`
   5. Use "request review" to notify the reviewer once you have resolved the review
   -->
   
   * [ ] Did you explain what problem does this PR solve? Or what new features have been added?
   * [ ] Have you added corresponding test cases?
   * [ ] Have you modified the corresponding document?
   * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix-ingress-controller#community) first**
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#issuecomment-1141893599

   # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1031](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c4e6835) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/3cccd5666e098f374c262eb443de194d69d6a55e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3cccd56) will **increase** coverage by `0.17%`.
   > The diff coverage is `34.72%`.
   
   > :exclamation: Current head c4e6835 differs from pull request most recent head 17cfb9a. Consider uploading reports for the commit 17cfb9a to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1031      +/-   ##
   ==========================================
   + Coverage   30.87%   31.04%   +0.17%     
   ==========================================
     Files          74       77       +3     
     Lines        8373     9070     +697     
   ==========================================
   + Hits         2585     2816     +231     
   - Misses       5511     5951     +440     
   - Partials      277      303      +26     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/ingress/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NvbnN1bWVyLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/compare.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29tcGFyZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `0.86% <0.00%> (-0.04%)` | :arrow_down: |
   | [pkg/ingress/gateway\_httproute.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZ2F0ZXdheV9odHRwcm91dGUuZ28=) | `0.00% <0.00%> (ø)` | |
   | [pkg/ingress/status.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc3RhdHVzLmdv) | `0.00% <0.00%> (ø)` | |
   | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | `61.53% <ø> (ø)` | |
   | [pkg/kube/translation/annotations/csrf.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvY3NyZi5nbw==) | `0.00% <0.00%> (ø)` | |
   | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `20.60% <0.00%> (-0.55%)` | :arrow_down: |
   | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `46.07% <ø> (ø)` | |
   | [pkg/types/event.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL3R5cGVzL2V2ZW50Lmdv) | `100.00% <ø> (ø)` | |
   | ... and [6 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [3cccd56...17cfb9a](https://codecov.io/gh/apache/apisix-ingress-controller/pull/1031?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 merged pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
tao12345666333 merged PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#issuecomment-1143453955

   Please merge latest code, and resolve the conflicts. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r879000758


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/#:~:text=%E5%8F%82%E8%A7%81%20%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6-,%E6%AD%A5%E9%AA%A45%EF%BC%9A%E4%BF%AE%E6%94%B9%20Admin%20API%20key,-%23) to simply change Apache APISIX.

Review Comment:
   Solved~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r887618409


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two different ways to implement the requirements here.
+
+For the first method, we need to modify the Admin API credentials values in both the `apisix/values.yaml` and `apisix/apisix-ingress-controller/values.yaml` files. You can refer to these two links(apisix's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#:~:text=admin%3A%20edd1c9f034335f136f87ad84b625c8f1) && apisix-ingress-controller's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#:~:text=adminKey%3A%20%22edd1c9f034335f136f87ad84b625c8f1%22)).

Review Comment:
   Solved~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#issuecomment-1144334912

   @tao12345666333 Got it~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r885402381


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two ways to implement the requirements here.
+
+In one method, we need to change the values of the two values.yaml files in the helm chart We need to change the Admin API key values in both helm chart packages.

Review Comment:
   I have changed the description of the first method.
   Please review it, sir.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r887520349


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two different ways to implement the requirements here.
+
+For the first method, we need to modify the Admin API credentials values in both the `apisix/values.yaml` and `apisix/apisix-ingress-controller/values.yaml` files. You can refer to these two links(apisix's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#:~:text=admin%3A%20edd1c9f034335f136f87ad84b625c8f1) && apisix-ingress-controller's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#:~:text=adminKey%3A%20%22edd1c9f034335f136f87ad84b625c8f1%22)).

Review Comment:
   please use permalink
   
   https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix/values.yaml#L181
   
   https://github.com/apache/apisix-helm-chart/blob/57cdbe461765cd49af2195cc6a1976cc55262e9b/charts/apisix-ingress-controller/values.yaml#L128
   



##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.

Review Comment:
   you should link to https://apisix.apache.org/docs/apisix/how-to-build/#updating-admin-api-key



##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.

Review Comment:
   And modify the admin key just to protect Apache APISIX



##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two different ways to implement the requirements here.
+
+For the first method, we need to modify the Admin API credentials values in both the `apisix/values.yaml` and `apisix/apisix-ingress-controller/values.yaml` files. You can refer to these two links(apisix's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#:~:text=admin%3A%20edd1c9f034335f136f87ad84b625c8f1) && apisix-ingress-controller's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#:~:text=adminKey%3A%20%22edd1c9f034335f136f87ad84b625c8f1%22)).
+
+Another method, you can just pass `--set ingress-controller.config.apisix.adminKey=<Your new admin key>`  to `helm install` command.

Review Comment:
   In the first method, you modify the admin key of APISIX and APISIX Ingress, but in the second method, you only modify the admin key of APISIX Ingress.
   Please keep them consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tokers commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r879367502


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two ways to implement the requirements here.
+
+In one method, we need to change the values of the two values.yaml files in the helm chart We need to change the Admin API key values in both helm chart packages.

Review Comment:
   This sentence makes me confused. Which values should we modify?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#issuecomment-1143454780

   If you need any help, please ping me directly 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] juzhiyuan commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r878635767


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/#:~:text=%E5%8F%82%E8%A7%81%20%E6%B5%8B%E8%AF%95%E6%A1%86%E6%9E%B6-,%E6%AD%A5%E9%AA%A45%EF%BC%9A%E4%BF%AE%E6%94%B9%20Admin%20API%20key,-%23) to simply change Apache APISIX.

Review Comment:
   ```suggestion
   Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r880621262


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two ways to implement the requirements here.
+
+In one method, we need to change the values of the two values.yaml files in the helm chart We need to change the Admin API key values in both helm chart packages.

Review Comment:
   > This sentence makes me confused. Which values should we modify?
   
   +1. 
   
   If the description is not clear, please paste the specific code directly, it will be clearer



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r890065590


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two different ways to implement the requirements here.
+
+For the first method, we need to modify the Admin API credentials values in both the `apisix/values.yaml` and `apisix/apisix-ingress-controller/values.yaml` files. You can refer to these two links(apisix's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix/values.yaml#:~:text=admin%3A%20edd1c9f034335f136f87ad84b625c8f1) && apisix-ingress-controller's [values.yaml](https://github.com/apache/apisix-helm-chart/blob/master/charts/apisix-ingress-controller/values.yaml#:~:text=adminKey%3A%20%22edd1c9f034335f136f87ad84b625c8f1%22)).
+
+Another method, you can just pass `--set ingress-controller.config.apisix.adminKey=<Your new admin key>`  to `helm install` command.

Review Comment:
   Solved!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r879476160


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.
+
+However, in apisix-ingress-controller, if we need to change the Admin API key, we also need to change the Admin API key in apisix-ingress-controller. There are two ways to implement the requirements here.
+
+In one method, we need to change the values of the two values.yaml files in the helm chart We need to change the Admin API key values in both helm chart packages.

Review Comment:
   Let me refine it a little～



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-ingress-controller] Chever-John commented on a diff in pull request #1031: doc(APISIX-Ingress): add how to change Admin API key of Apache APISIX…

Posted by GitBox <gi...@apache.org>.
Chever-John commented on code in PR #1031:
URL: https://github.com/apache/apisix-ingress-controller/pull/1031#discussion_r887617808


##########
docs/en/latest/FAQ.md:
##########
@@ -76,3 +76,13 @@ kubectl get crd apisixroutes.apisix.apache.org -o jsonpath='{ .spec.versions[*].
 If you can not find `v2beta3` in `ApisixRoute` definition file. Please apply the latest version of `ApisixRoute`.
 
 Ref to FAQ #7.
+
+### 9. Modify the Admin API key in APISIX-Ingress
+
+Usually, you need to modify the Admin API key to protect Apache APISIX and APISIX Ingress. Please refer to this [link](https://apisix.apache.org/zh/docs/apisix/how-to-build/) to simply change Apache APISIX.

Review Comment:
   Solved~



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org