You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/15 05:48:52 UTC

[GitHub] [shardingsphere] tuichenchuxin opened a new pull request, #20184: Remove TransactionHolder.java

tuichenchuxin opened a new pull request, #20184:
URL: https://github.com/apache/shardingsphere/pull/20184

   for #20005
   
   Changes proposed in this pull request:
   - remove TransactionHolder.java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #20184: Remove TransactionHolder.java

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #20184:
URL: https://github.com/apache/shardingsphere/pull/20184#discussion_r945488079


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/session/ConnectionContext.java:
##########
@@ -62,4 +65,11 @@ public void clearTrafficInstance() {
     public void clearCursorConnectionContext() {
         cursorConnectionContext.close();
     }
+    
+    /**
+     * Clear transaction connection context.
+     */
+    public void clearTransactionConnectionContext() {

Review Comment:
   Please add clearTransactionConnectionContext in close method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #20184: Remove TransactionHolder.java

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20184:
URL: https://github.com/apache/shardingsphere/pull/20184#issuecomment-1214696698

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20184?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#20184](https://codecov.io/gh/apache/shardingsphere/pull/20184?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a54e253) into [master](https://codecov.io/gh/apache/shardingsphere/commit/18b6e57b7f2aaf3633b51bb1d236987abccb9170?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (18b6e57) will **decrease** coverage by `0.01%`.
   > The diff coverage is `76.92%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #20184      +/-   ##
   ============================================
   - Coverage     60.54%   60.52%   -0.02%     
     Complexity     2422     2422              
   ============================================
     Files          3874     3874              
     Lines         54794    54793       -1     
     Branches       7679     7679              
   ============================================
   - Hits          33175    33166       -9     
   - Misses        18760    18768       +8     
     Partials       2859     2859              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20184?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../dbdiscovery/route/DatabaseDiscoverySQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZGItZGlzY292ZXJ5L3NoYXJkaW5nc3BoZXJlLWRiLWRpc2NvdmVyeS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9kYmRpc2NvdmVyeS9yb3V0ZS9EYXRhYmFzZURpc2NvdmVyeVNRTFJvdXRlci5qYXZh) | `95.23% <ø> (ø)` | |
   | [...nce/FixedPrimaryReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvRml4ZWRQcmltYXJ5UmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `60.00% <ø> (ø)` | |
   | [...ransactionRandomReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25SYW5kb21SZWFkUXVlcnlMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `66.66% <ø> (ø)` | |
   | [...actionRoundRobinReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25Sb3VuZFJvYmluUmVhZFF1ZXJ5TG9hZEJhbGFuY2VBbGdvcml0aG0uamF2YQ==) | `66.66% <ø> (ø)` | |
   | [...ransactionWeightReadQueryLoadBalanceAlgorithm.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtcmVhZHdyaXRlLXNwbGl0dGluZy9zaGFyZGluZ3NwaGVyZS1yZWFkd3JpdGUtc3BsaXR0aW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3JlYWR3cml0ZXNwbGl0dGluZy9hbGdvcml0aG0vbG9hZGJhbGFuY2UvVHJhbnNhY3Rpb25XZWlnaHRSZWFkUXVlcnlMb2FkQmFsYW5jZUFsZ29yaXRobS5qYXZh) | `69.38% <ø> (ø)` | |
   | [...e/shardingsphere/shadow/route/ShadowSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhZG93L3NoYXJkaW5nc3BoZXJlLXNoYWRvdy1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFkb3cvcm91dGUvU2hhZG93U1FMUm91dGVyLmphdmE=) | `33.33% <ø> (ø)` | |
   | [...phere/sharding/route/engine/ShardingSQLRouter.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL1NoYXJkaW5nU1FMUm91dGVyLmphdmE=) | `78.94% <ø> (ø)` | |
   | [...hardingsphere/infra/session/ConnectionContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zZXNzaW9uL0Nvbm5lY3Rpb25Db250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | |
   | [...sion/transaction/TransactionConnectionContext.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9zZXNzaW9uL3RyYW5zYWN0aW9uL1RyYW5zYWN0aW9uQ29ubmVjdGlvbkNvbnRleHQuamF2YQ==) | `0.00% <0.00%> (ø)` | |
   | [...e/infra/route/engine/impl/AllSQLRouteExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtcm91dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL3JvdXRlL2VuZ2luZS9pbXBsL0FsbFNRTFJvdXRlRXhlY3V0b3IuamF2YQ==) | `100.00% <ø> (ø)` | |
   | ... and [19 more](https://codecov.io/gh/apache/shardingsphere/pull/20184/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tuichenchuxin commented on a diff in pull request #20184: Remove TransactionHolder.java

Posted by GitBox <gi...@apache.org>.
tuichenchuxin commented on code in PR #20184:
URL: https://github.com/apache/shardingsphere/pull/20184#discussion_r945561004


##########
shardingsphere-infra/shardingsphere-infra-common/src/main/java/org/apache/shardingsphere/infra/session/ConnectionContext.java:
##########
@@ -62,4 +65,11 @@ public void clearTrafficInstance() {
     public void clearCursorConnectionContext() {
         cursorConnectionContext.close();
     }
+    
+    /**
+     * Clear transaction connection context.
+     */
+    public void clearTransactionConnectionContext() {

Review Comment:
   Done. Thank you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu merged pull request #20184: Remove TransactionHolder.java

Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20184:
URL: https://github.com/apache/shardingsphere/pull/20184


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org