[GitHub] betodealmeida commented on a change in pull request #5663: Make brush send events

[GitBox <gi...@apache.org>]

betodealmeida commented on a change in pull request #5663: Make brush send events
URL: https://github.com/apache/incubator-superset/pull/5663#discussion_r211041864
 
 

 ##########
 File path: superset/assets/src/explore/visTypes.jsx
 ##########
 @@ -179,7 +179,7 @@ export const visTypes = {
         expanded: true,
         controlSetRows: [
           ['color_scheme'],
-          ['show_brush', 'show_legend'],
+          ['show_brush', 'send_time_range', 'show_legend'],
 
 Review comment:
   I know we rarely use 3 elements in the same row, but I think it works in this case:
   
   <img width="534" alt="screen shot 2018-08-17 at 2 51 12 pm" src="https://user-images.githubusercontent.com/1534870/44290471-b34a0200-a22d-11e8-90ea-cc0c26e93d62.png">
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org