You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2020/10/02 08:57:20 UTC

[Bug 64784] New: Add option to remove date from generated Java header comment

https://bz.apache.org/bugzilla/show_bug.cgi?id=64784

            Bug ID: 64784
           Summary: Add option to remove date from generated Java header
                    comment
           Product: Tomcat 10
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Jasper
          Assignee: dev@tomcat.apache.org
          Reporter: niklas@chrono24.com
  Target Milestone: ------

Currently, org.apache.jasper.compiler.Generator#generateCommentHeader writes
the current timestamp using `new Date()` into the comment header, which makes
builds keeping sources non-reproducible, because the timestamp changes with
each precompile.

There should be an option to disable or override this timestamp or maybe it can
be removed completely?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64784] Add option to remove date from generated Java header comment

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64784

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Mark Thomas <ma...@apache.org> ---
Fixed in:
- 10.0.x for 10.0.0-M10 onwards
- 9.0.x for 9.0.40 onwards

Disabled for pre-compiled files. Retained for on-the-fly compilation.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64784] Add option to remove date from generated Java header comment

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64784

--- Comment #2 from Mark Thomas <ma...@apache.org> ---
The date was added to the .java file to aid trouble shooting JSP compilation
issues and remind system admins that the last modified time of the file will
reflect the last modified time of the JSP source rather than the time the file
was generated.

As far as I recall this wasn't requested by users but was something we added
proactively when we started changing the last modified time although it would
be worth a trawl through the archives to confirm my recollection.

I'm not against removing it entirely. I've done a fair amount of debugging of
JSP generation and I don't recall using it. If we wanted to be cautious we
could probably remove it when precompiling but leave it when compiling on
demand.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64784] Add option to remove date from generated Java header comment

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64784

--- Comment #1 from Michael Osipov <mi...@apache.org> ---
I would favor to remove it completely. It adds zero benefit.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

[Bug 64784] Add option to remove date from generated Java header comment

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64784

--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> ---
+1 to at least removing it from a precompile.

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org