You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jan Schlicht <ja...@mesosphere.io> on 2015/11/11 15:16:05 UTC
Review Request 40187: Fixed and formatted JSON examples.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/
-----------------------------------------------------------
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Bugs: MESOS-3899
https://issues.apache.org/jira/browse/MESOS-3899
Repository: mesos
Description
-------
Fixed and formatted JSON examples (using 2 space indentation)
Diffs
-----
src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
Diff: https://reviews.apache.org/r/40187/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Jan Schlicht <ja...@mesosphere.io>.
> On Nov. 17, 2015, 6:27 a.m., Neil Conway wrote:
> > This should also update docs/configuration.md
Thanks! Fortunately `docs/configuration.md` looks very good overall. Just a comma too much -- though I hope that I haven't overlooked something there.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106797
-----------------------------------------------------------
On Nov. 11, 2015, 3:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 3:16 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106797
-----------------------------------------------------------
This should also update docs/configuration.md
- Neil Conway
On Nov. 11, 2015, 2:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106064
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40187]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2015, 2:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106838
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40187]
All tests passed.
- Mesos ReviewBot
On Nov. 17, 2015, 10:41 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 10:41 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106831
-----------------------------------------------------------
Ship it!
Ship It!
- Neil Conway
On Nov. 17, 2015, 10:41 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 10:41 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review107947
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On Nov. 17, 2015, 10:41 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 17, 2015, 10:41 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Jan Schlicht <ja...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/
-----------------------------------------------------------
(Updated Nov. 17, 2015, 11:41 a.m.)
Review request for mesos, Benjamin Bannier and Till Toenshoff.
Changes
-------
Add `docs/configuration.md`.
Bugs: MESOS-3899
https://issues.apache.org/jira/browse/MESOS-3899
Repository: mesos
Description
-------
Fixed and formatted JSON examples (using 2 space indentation)
Diffs (updated)
-----
docs/configuration.md 72847e5efe7008fdec8287cce100857f9e7c0fe0
src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c
Diff: https://reviews.apache.org/r/40187/diff/
Testing
-------
make check
Thanks,
Jan Schlicht
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106059
-----------------------------------------------------------
Ship it!
- Benjamin Bannier
On Nov. 11, 2015, 2:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
Re: Review Request 40187: Fixed and formatted JSON examples.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40187/#review106065
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40187]
All tests passed.
- Mesos ReviewBot
On Nov. 11, 2015, 2:16 p.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40187/
> -----------------------------------------------------------
>
> (Updated Nov. 11, 2015, 2:16 p.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Bugs: MESOS-3899
> https://issues.apache.org/jira/browse/MESOS-3899
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed and formatted JSON examples (using 2 space indentation)
>
>
> Diffs
> -----
>
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6
>
> Diff: https://reviews.apache.org/r/40187/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>