You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TaoZex (via GitHub)" <gi...@apache.org> on 2023/01/23 06:34:43 UTC
[GitHub] [incubator-seatunnel] TaoZex opened a new pull request, #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
TaoZex opened a new pull request, #3987:
URL: https://github.com/apache/incubator-seatunnel/pull/3987
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex commented on pull request #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex commented on PR #3987:
URL: https://github.com/apache/incubator-seatunnel/pull/3987#issuecomment-1400597332
> In a real production scenario, it would not have all records with the same timestamp. Hey guys, what do you think about it? cc @EricJoy2048 @CalvinKirs @Hisoka-X @hailin0 @ashulin
How about support for parsing the value of a column of SeatunnelRow as timestamp? It is common to use timestamp to distinguish between event time and processing time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #3987:
URL: https://github.com/apache/incubator-seatunnel/pull/3987#issuecomment-1400579792
In a real production scenario, it would not have all records with the same timestamp. Hey guys, what do you think about it? cc @EricJoy2048 @CalvinKirs @Hisoka-X @hailin0 @ashulin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TaoZex closed pull request #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
Posted by "TaoZex (via GitHub)" <gi...@apache.org>.
TaoZex closed pull request #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
URL: https://github.com/apache/incubator-seatunnel/pull/3987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
Posted by "TyrantLucifer (via GitHub)" <gi...@apache.org>.
TyrantLucifer commented on PR #3987:
URL: https://github.com/apache/incubator-seatunnel/pull/3987#issuecomment-1400666613
> > In a real production scenario, it would not have all records with the same timestamp. Hey guys, what do you think about it? cc @EricJoy2048 @CalvinKirs @Hisoka-X @hailin0 @ashulin
>
> How about support for parsing the value of a column of SeatunnelRow as timestamp? It is common to use timestamp to distinguish between event time and processing time.
In my experience, there is no situation where timestamp is specified manually, because the business value of timestamp is different between producer record and data like the time semantics of flink. One is the data generate time, another is the event happen time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3987: [Feature][connector][kafka] Add timestamp for kafka sink record
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #3987:
URL: https://github.com/apache/incubator-seatunnel/pull/3987#issuecomment-1401435147
Timestamp just a normal field in SeaTunnel, not any speical at now.
> > In a real production scenario, it would not have all records with the same timestamp. Hey guys, what do you think about it? cc @EricJoy2048 @CalvinKirs @Hisoka-X @hailin0 @ashulin
>
> How about support for parsing the value of a column of SeatunnelRow as timestamp? It is common to use timestamp to distinguish between event time and processing time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org