MINA 2.2.8 potential Zlib init failure in CompressionFilter

[Joerg Michelberger <j....@gmail.com>]

Hello all,
inspecting the CompressionFilter change, introduced in 2.2.8, it seems that
there crept in a cut and paste error in the initialisation of the Zlib used
for deflate. It is literally the same initialization as for the inflate.
See:
https://github.com/apache/mina/blob/2.2.X/mina-filter-compression/src/main/java/org/apache/mina/filter/compression/CompressionFilter.java#L280

In 2.2.7 is the inflate Zlib initialized with Zlib.MODE_INFLATER and the
deflate with Zlib.MODE_DEFLATE.
In 2.2.8 are both with Zlib.MODE_INFLATER.
I do not think that this is the intention.

Same on 2.0.x and 2.1.x branches.

Regards
Jörg

Re: MINA 2.2.8 potential Zlib init failure in CompressionFilter

[Emmanuel Lecharny <el...@gmail.com>]

Hi Joerg,

well, indeed :/ This is clearly a copy/past error...

It's sad that the unit tests didn't caught the obvious error.

We are good for a patch and a release...


Many thanks for the report!

On 6/8/26 20:31, Joerg Michelberger wrote:
> Hello all,
> inspecting the CompressionFilter change, introduced in 2.2.8, it seems that
> there crept in a cut and paste error in the initialisation of the Zlib used
> for deflate. It is literally the same initialization as for the inflate.
> See:
> https://github.com/apache/mina/blob/2.2.X/mina-filter-compression/src/main/java/org/apache/mina/filter/compression/CompressionFilter.java#L280
>
> In 2.2.7 is the inflate Zlib initialized with Zlib.MODE_INFLATER and the
> deflate with Zlib.MODE_DEFLATE.
> In 2.2.8 are both with Zlib.MODE_INFLATER.
> I do not think that this is the intention.
>
> Same on 2.0.x and 2.1.x branches.
>
> Regards
> Jörg
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org