You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/12/03 01:57:16 UTC

[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys

DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662558


##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
           + CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
           + CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
 
-  private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
-          = LOCATION_INFO_GROUP_ONE_SIZE;
 
   private static final long LOCATION_INFO_GROUP_TWO_SIZE
       = CONTAINER_FOUR_REPLICA_COUNT * BLOCK_FOUR_LENGTH
       + CONTAINER_FIVE_REPLICA_COUNT * BLOCK_FIVE_LENGTH
       + CONTAINER_SIX_REPLICA_COUNT * BLOCK_SIX_LENGTH;
 
   private static final long FILE1_SIZE_WITH_REPLICA =
-      LOCATION_INFO_GROUP_ONE_SIZE;
+      getReplicatedSize(KEY_ONE_SIZE,

Review Comment:
   ohh yes! From the original testing setting it set up these files with the single replica!
   (https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java#L218)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org