[GitHub] [lucene] dweiss commented on a change in pull request #61: LUCENE-9900: Regenerate/ run ICU only if inputs changed

[GitBox <gi...@apache.org>]

dweiss commented on a change in pull request #61:
URL: https://github.com/apache/lucene/pull/61#discussion_r606134465



##########
File path: gradle/generation/icu.gradle
##########
@@ -49,6 +49,13 @@ configure(project(":lucene:analysis:icu")) {
     // May be undefined yet, so use a provider.
     dependsOn { sourceSets.tools.runtimeClasspath }
 
+    // gennorm generates file order-dependent output, so make it constant here.

Review comment:
       @rmuir gennorm seems to be order-sensitive - I changed the order to sorted file names - that's why it's regenerated as part of this patch. Is this order somehow important? I can revert to what it was before but this way it's simpler.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org