You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/30 02:12:26 UTC
Review Request 33705: Don't retry API requests that fail with auth
errors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Kevin Sweeney.
Bugs: AURORA-1248
https://issues.apache.org/jira/browse/AURORA-1248
Repository: aurora
Description
-------
The only thing i really don't care for in this patch is that `add_auth_error_handler` alters a 'private' field, but i was unable to come up with an alternative that wouldn't seem to spiral into a refactor. Advice/opinions solicited.
Diffs
-----
src/main/python/apache/aurora/client/api/scheduler_client.py 3f9c691056ee50103a7857bea43160c75388f2aa
src/main/python/apache/aurora/client/cli/__init__.py 10d943215282a83ebe0cadac1592848d797c3e79
src/main/python/apache/aurora/client/cli/context.py adbffc4aa07c242691e87e0fcfc9f5b840999d1d
src/main/python/apache/aurora/common/transport.py eefe8f7b50e0e0040e28ff47b226e91316f1911e
src/test/python/apache/aurora/client/api/test_scheduler_client.py 9319728d3a95b158cb734f4cbc6be97187d43def
src/test/python/apache/aurora/client/cli/test_context.py d63f060ea6cf747792f27499da901dd7cecae596
src/test/python/apache/aurora/common/test_transport.py e4f93ef9dd6bf0d54166bdf6afb247fad871ea10
src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh cc7cdee42b7c03dd1f121963129d94e67cb9e2a2
Diff: https://reviews.apache.org/r/33705/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 33705: Don't retry API requests that fail with auth
errors.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/#review82071
-----------------------------------------------------------
Ship it!
Master (f77daf7) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 30, 2015, 12:12 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33705/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 12:12 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Bugs: AURORA-1248
> https://issues.apache.org/jira/browse/AURORA-1248
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The only thing i really don't care for in this patch is that `add_auth_error_handler` alters a 'private' field, but i was unable to come up with an alternative that wouldn't seem to spiral into a refactor. Advice/opinions solicited.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 3f9c691056ee50103a7857bea43160c75388f2aa
> src/main/python/apache/aurora/client/cli/__init__.py 10d943215282a83ebe0cadac1592848d797c3e79
> src/main/python/apache/aurora/client/cli/context.py adbffc4aa07c242691e87e0fcfc9f5b840999d1d
> src/main/python/apache/aurora/common/transport.py eefe8f7b50e0e0040e28ff47b226e91316f1911e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 9319728d3a95b158cb734f4cbc6be97187d43def
> src/test/python/apache/aurora/client/cli/test_context.py d63f060ea6cf747792f27499da901dd7cecae596
> src/test/python/apache/aurora/common/test_transport.py e4f93ef9dd6bf0d54166bdf6afb247fad871ea10
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh cc7cdee42b7c03dd1f121963129d94e67cb9e2a2
>
> Diff: https://reviews.apache.org/r/33705/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33705: Don't retry API requests that fail with auth
errors.
Posted by Bill Farner <wf...@apache.org>.
> On April 30, 2015, 7:15 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/common/transport.py, line 64
> > <https://reviews.apache.org/r/33705/diff/1/?file=945910#file945910line64>
> >
> > Is this meant to indicate that it should be a function that returns a Session? Is this a standard that's documented somewhere?
Yes, that's what it indicates. I made this change to address warnings that PyCharm was showing, since the type hint was incorrect.
I couldn't find details on whether this is more broad than PyCharm, but docs are here: https://www.jetbrains.com/pycharm/help/type-hinting-in-pycharm.html#d269326e143
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/#review82172
-----------------------------------------------------------
On April 30, 2015, 12:12 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33705/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 12:12 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Bugs: AURORA-1248
> https://issues.apache.org/jira/browse/AURORA-1248
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The only thing i really don't care for in this patch is that `add_auth_error_handler` alters a 'private' field, but i was unable to come up with an alternative that wouldn't seem to spiral into a refactor. Advice/opinions solicited.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 3f9c691056ee50103a7857bea43160c75388f2aa
> src/main/python/apache/aurora/client/cli/__init__.py 10d943215282a83ebe0cadac1592848d797c3e79
> src/main/python/apache/aurora/client/cli/context.py adbffc4aa07c242691e87e0fcfc9f5b840999d1d
> src/main/python/apache/aurora/common/transport.py eefe8f7b50e0e0040e28ff47b226e91316f1911e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 9319728d3a95b158cb734f4cbc6be97187d43def
> src/test/python/apache/aurora/client/cli/test_context.py d63f060ea6cf747792f27499da901dd7cecae596
> src/test/python/apache/aurora/common/test_transport.py e4f93ef9dd6bf0d54166bdf6afb247fad871ea10
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh cc7cdee42b7c03dd1f121963129d94e67cb9e2a2
>
> Diff: https://reviews.apache.org/r/33705/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33705: Don't retry API requests that fail with auth
errors.
Posted by Joshua Cohen <jc...@apache.org>.
> On April 30, 2015, 7:15 p.m., Joshua Cohen wrote:
> > src/main/python/apache/aurora/common/transport.py, line 64
> > <https://reviews.apache.org/r/33705/diff/1/?file=945910#file945910line64>
> >
> > Is this meant to indicate that it should be a function that returns a Session? Is this a standard that's documented somewhere?
>
> Bill Farner wrote:
> Yes, that's what it indicates. I made this change to address warnings that PyCharm was showing, since the type hint was incorrect.
>
> I couldn't find details on whether this is more broad than PyCharm, but docs are here: https://www.jetbrains.com/pycharm/help/type-hinting-in-pycharm.html#d269326e143
Thanks, good to know.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/#review82172
-----------------------------------------------------------
On April 30, 2015, 12:12 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33705/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 12:12 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Bugs: AURORA-1248
> https://issues.apache.org/jira/browse/AURORA-1248
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The only thing i really don't care for in this patch is that `add_auth_error_handler` alters a 'private' field, but i was unable to come up with an alternative that wouldn't seem to spiral into a refactor. Advice/opinions solicited.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 3f9c691056ee50103a7857bea43160c75388f2aa
> src/main/python/apache/aurora/client/cli/__init__.py 10d943215282a83ebe0cadac1592848d797c3e79
> src/main/python/apache/aurora/client/cli/context.py adbffc4aa07c242691e87e0fcfc9f5b840999d1d
> src/main/python/apache/aurora/common/transport.py eefe8f7b50e0e0040e28ff47b226e91316f1911e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 9319728d3a95b158cb734f4cbc6be97187d43def
> src/test/python/apache/aurora/client/cli/test_context.py d63f060ea6cf747792f27499da901dd7cecae596
> src/test/python/apache/aurora/common/test_transport.py e4f93ef9dd6bf0d54166bdf6afb247fad871ea10
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh cc7cdee42b7c03dd1f121963129d94e67cb9e2a2
>
> Diff: https://reviews.apache.org/r/33705/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33705: Don't retry API requests that fail with auth
errors.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33705/#review82172
-----------------------------------------------------------
Ship it!
I'm not *too* concerned about accessing the `_scheduler_proxy` property directly, but if you're really worried you could expose wrapping the proxy via a method on the api object (not sure if the use case warrants such a broad mechanism though?).
src/main/python/apache/aurora/common/transport.py
<https://reviews.apache.org/r/33705/#comment132880>
Is this meant to indicate that it should be a function that returns a Session? Is this a standard that's documented somewhere?
- Joshua Cohen
On April 30, 2015, 12:12 a.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33705/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 12:12 a.m.)
>
>
> Review request for Aurora, Joshua Cohen and Kevin Sweeney.
>
>
> Bugs: AURORA-1248
> https://issues.apache.org/jira/browse/AURORA-1248
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The only thing i really don't care for in this patch is that `add_auth_error_handler` alters a 'private' field, but i was unable to come up with an alternative that wouldn't seem to spiral into a refactor. Advice/opinions solicited.
>
>
> Diffs
> -----
>
> src/main/python/apache/aurora/client/api/scheduler_client.py 3f9c691056ee50103a7857bea43160c75388f2aa
> src/main/python/apache/aurora/client/cli/__init__.py 10d943215282a83ebe0cadac1592848d797c3e79
> src/main/python/apache/aurora/client/cli/context.py adbffc4aa07c242691e87e0fcfc9f5b840999d1d
> src/main/python/apache/aurora/common/transport.py eefe8f7b50e0e0040e28ff47b226e91316f1911e
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 9319728d3a95b158cb734f4cbc6be97187d43def
> src/test/python/apache/aurora/client/cli/test_context.py d63f060ea6cf747792f27499da901dd7cecae596
> src/test/python/apache/aurora/common/test_transport.py e4f93ef9dd6bf0d54166bdf6afb247fad871ea10
> src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh cc7cdee42b7c03dd1f121963129d94e67cb9e2a2
>
> Diff: https://reviews.apache.org/r/33705/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>